[Discover] Skip 'context view for date_nanos with custom timestamp' functional test#56178
Merged
tylersmalley merged 1 commit intoelastic:masterfrom Jan 28, 2020
Conversation
tylersmalley
approved these changes
Jan 28, 2020
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Contributor
|
hello @kertal , |
Member
Author
|
Hi, thanks for reminding 👍 , I've to write a ticket in the Elasticsearch repo, and add an issue in Kibana, to enable the test when the invalid request works in ES (It did for a while) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Due to a recent change in ElasticSearch the functional tests of Discover's Context view using
date_nanoswith custom timestamp format are failingManually Reproduce it:
Use latest snapshot
Install testdata:
it uses the following mapping of the timestamp:
Use this link to get to the error message:
Reproduce the error via console
Works when providing the
search_aftervalue a number (However we need to provide it as text, because the browsers can't handle BigInt)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately