[7.x] [Vis: Default editor] EUIficate and Reactify the sidebar (#49864)#55162
Merged
sulemanof merged 1 commit intoelastic:7.xfrom Jan 17, 2020
Merged
[7.x] [Vis: Default editor] EUIficate and Reactify the sidebar (#49864)#55162sulemanof merged 1 commit intoelastic:7.xfrom
sulemanof merged 1 commit intoelastic:7.xfrom
Conversation
* EUIficate the sidebar * Create a state reducer and a state context * Create an editor context and actions * Improve types * Apply aggs reordering * Fix functionality * Improve types * Fix sub_agg changes * Remove legacy dependencies * Watch dirty state * Fix dirty state changes * Update actions and reducers * Handle keyboard submit * Apply editor form validation * Remove fancy forms * Update validation * Use embeddable instead of visualize loader * Add auto apply behavior * Remove legacy styles * Remove the sidebar * Restrict responsive to the bottom_bar * Upgrade @elastic/eui to v14.10.0 * Replace EuiBottomBar with EuiControlBar * Get rid of mutations in control vis * Revert "Upgrade @elastic/eui to v14.10.0" This reverts commit 2cd86c5. * Replace bottom bar with a control panel for sidebar * Replace selectors * Use editor resizer * Apply selectors * Change selectors * Fix sub agg change values * Add collapse button * Fix tests * Get rid of editor editor_state_context, simplify the code * Fix jest tests, update snapshots * Fix types * Moving collapse button to right of index pattern * Tweaks bottom buttons * Moved Vega buttons so they don’t scroll away * Fix responsiveness * Resolve UI comments * Fix console resizer * Update dev docs * Bail out of additional render in metrics and axes * Apply performance optimizations for metrics and axis panel * Remove unused translations * Use debounce when autoapply enabled Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/legacy/plugins/rollup/public/visualize/editor_config.js # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: