Skip to content

[7.x] [SIEM][Detection Engine] Silence 409 errors on signal creation (#53859)#53903

Merged
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-53859
Jan 3, 2020
Merged

[7.x] [SIEM][Detection Engine] Silence 409 errors on signal creation (#53859)#53903
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-53859

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Jan 2, 2020

Backports the following commits to 7.x:

…ic#53859)

* Remove punctuation from translation

We already had a colon on both uses of this key, resulting in '::' on
the page.

* Ignore 409 errors from our signal creation

In my experience these are always due to a rule being run multiple times
on the same document, generating a duplicate signal with a (correctly)
duplicate id. Only if we encounter non-409 errors do we log a message to
the user.

* Hide 409 errors during signal creation

These are expected and potentially confusing to the user. Instead, we
only show unexpected errors.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rylnd rylnd added the backport This PR is a backport of another PR label Jan 2, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 126da30 into elastic:7.x Jan 3, 2020
@rylnd rylnd deleted the backport/7.x/pr-53859 branch January 3, 2020 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants