Skip to content

Revert pinned ES snapshot#53645

Closed
jbudz wants to merge 9 commits intoelastic:masterfrom
jbudz:issues/pinned-es-snapshot
Closed

Revert pinned ES snapshot#53645
jbudz wants to merge 9 commits intoelastic:masterfrom
jbudz:issues/pinned-es-snapshot

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Dec 19, 2019

Elasticsearch was pinned to an older version due to a migrations
failure. Root cause was determined to be upstream and tracked at
elastic/elasticsearch#50248. Now that a fix is merged we can see where
the most recent snapshot leaves us.

Elasticsearch was pinned to an older version due to a migrations
failure.  Root cause was determined to be upstream and tracked at
elastic/elasticsearch#50248.  Now that a fix is merged we can see where
the most recent snapshot leaves us.
Until new artifacts are built we need to build from source to test the
mappings fix.  This is for testing the most recent fixes and should be reverted before merging.
@jbudz jbudz changed the title Issues/pinned es snapshot Revert pinned ES snapshot Dec 19, 2019
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 20, 2019

retest

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 20, 2019

elastic/elasticsearch#49166 is next - short term we need to set fielddata to true.

In 8.0 field data is defaulted to false in Elasticsearch.  We make use
if this in several areas.  The setting change is to reduce
memory pressure.  The Kibana index typically isn't very large so this is
not expected to have a large impact.
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 20, 2019

Migrations are running on hash changes of mappings it looks like..need to push settings changes

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Copy Markdown
Member

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

exists: false,
indexName: index,
settings: {
'indices.id_field_data.enabled': true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this would do here. In addition, this is a cluster-level setting, so this won't work. I believe the solution here is to remove any sort/aggregating we have on _id

@tylersmalley
Copy link
Copy Markdown
Member

tylersmalley commented Jan 9, 2020

I have highlighted the path forward here: #52517 (comment). Since we're automating the snapshots, we no longer need this PR to unpin the snapshot once the sorting on _id has been removed.

@tylersmalley
Copy link
Copy Markdown
Member

This can be closed.

@jbudz jbudz closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants