Skip to content

[7.x] Infra server NP shim + config/routing API adoption (#45299)#52613

Merged
Kerry350 merged 7 commits intoelastic:7.xfrom
jasonrhodes:backport/7.x/pr-45299
Dec 11, 2019
Merged

[7.x] Infra server NP shim + config/routing API adoption (#45299)#52613
Kerry350 merged 7 commits intoelastic:7.xfrom
jasonrhodes:backport/7.x/pr-45299

Conversation

@Kerry350
Copy link
Copy Markdown
Contributor

@Kerry350 Kerry350 commented Dec 10, 2019

Backports the following commits to 7.x:

@Kerry350 Kerry350 added the backport This PR is a backport of another PR label Dec 10, 2019
@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 10, 2019

Test failures look unrelated:

    Kibana Pipeline / kibana-intake-agent / kibana-intake / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running with es instance 'yarn start' should result in the spec plugin being initialized on kibana's stdout
    Kibana Pipeline / kibana-intake-agent / kibana-intake / Jest Integration Tests.src/cli/serve/integration_tests.cli invalid config support exits with statusCode 64 and logs a single line when config is invalid

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 10, 2019

@elasticmachine merge upstream

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 10, 2019

@elasticmachine merge upstream

@weltenwort
Copy link
Copy Markdown
Member

weltenwort commented Dec 10, 2019

@elasticmachine merge upstream

@weltenwort weltenwort mentioned this pull request Dec 10, 2019
Merged
1 task
@weltenwort
Copy link
Copy Markdown
Member

weltenwort commented Dec 10, 2019

This might actually be relevant:

00:14:58.288   info [  kibana  ] Running optimizer
00:14:58.288     │ debg Temporarily installing node.js for linux-x64
00:15:00.810     │ info Running bin/kibana to trigger the optimizer
00:15:00.810     │ debg $ ./bin/kibana --env.name=production --logging.json=false --optimize
00:15:02.180     │ debg   log   [18:41:41.590] [error][plugins-service] { Error: Plugin "infra" is only compatible with Kibana version "8.0.0", but used Kibana version is "7.6.0-SNAPSHOT". (incompatible-version, /dev/shm/workspace/kibana/build/kibana/x-pack/plugins/infra/kibana.json)
00:15:02.180     │ debg     at Function.incompatibleVersion (/dev/shm/workspace/kibana/build/kibana/src/core/server/plugins/discovery/plugin_discovery_error.js:43:12)
00:15:02.180     │ debg     at parseManifest (/dev/shm/workspace/kibana/build/kibana/src/core/server/plugins/discovery/plugin_manifest_parser.js:124:56)
00:15:02.180     │ debg   type: 'incompatible-version',
00:15:02.180     │ debg   path:
00:15:02.180     │ debg    '/dev/shm/workspace/kibana/build/kibana/x-pack/plugins/infra/kibana.json',
00:15:02.180     │ debg   cause:
00:15:02.180     │ debg    Error: Plugin "infra" is only compatible with Kibana version "8.0.0", but used Kibana version is "7.6.0-SNAPSHOT".
00:15:02.180     │ debg        at parseManifest (/dev/shm/workspace/kibana/build/kibana/src/core/server/plugins/discovery/plugin_manifest_parser.js:124:90) }
00:15:02.180     │ debg   log   [18:41:41.600] [fatal][root] Error: Failed to initialize plugins:
00:15:02.180     │ debg 	Plugin "infra" is only compatible with Kibana version "8.0.0", but used Kibana version is "7.6.0-SNAPSHOT". (incompatible-version, /dev/shm/workspace/kibana/build/kibana/x-pack/plugins/infra/kibana.json)
00:15:02.180     │ debg     at PluginsService.handleDiscoveryErrors (/dev/shm/workspace/kibana/build/kibana/src/core/server/plugins/plugins_service.js:109:13)
00:15:02.180     │ debg 
00:15:02.180     │ debg  FATAL  Error: Failed to initialize plugins:
00:15:02.180     │ debg 	Plugin "infra" is only compatible with Kibana version "8.0.0", but used Kibana version is "7.6.0-SNAPSHOT". (incompatible-version, /dev/shm/workspace/kibana/build/kibana/x-pack/plugins/infra/kibana.json)
00:15:02.180     │ debg 
00:15:02.180     │ERROR failure
00:15:02.180     │ERROR Error: Command failed with exit code 1: ./bin/kibana --env.name=production --logging.json=false --optimize
00:15:02.180     │          at makeError (/dev/shm/workspace/kibana/node_modules/execa/lib/error.js:56:11)
00:15:02.180     │          at handlePromise (/dev/shm/workspace/kibana/node_modules/execa/index.js:114:26)
00:15:02.180     │          at process._tickCallback (internal/process/next_tick.js:68:7)

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 10, 2019

@weltenwort Ah, nice catch. Looking in to this.

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 11, 2019

Okay, the kibanaVersion issue was fixed with be34a5b (this didn't appear on master as 8.0.0 aligns there, I have added this fix to #51615 for master).

The new test failure is unrelated. Running the suite locally I've had it pass once, and fail once, so it seems to be a bit flaky 😬

✓ pass  (12.9s) "dashboard app using legacy data dashboard save Saves on confirm duplicate title warning"

Going to give it another CI run.

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Dec 11, 2019

@elasticmachine merge upstream

@Kerry350 Kerry350 mentioned this pull request Dec 11, 2019
Closed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 11, 2019

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Kerry350 Kerry350 merged commit a2df167 into elastic:7.x Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kerry350 @weltenwort @elasticmachine @jasonrhodes