Skip to content

[Reporting/Legacy] Remove reporting legacy job params compatibility shim#52539

Merged
tsullivan merged 16 commits intoelastic:masterfrom
tsullivan:reporting/remove-6x-shims
Jan 6, 2020
Merged

[Reporting/Legacy] Remove reporting legacy job params compatibility shim#52539
tsullivan merged 16 commits intoelastic:masterfrom
tsullivan:reporting/remove-6x-shims

Conversation

@tsullivan
Copy link
Copy Markdown
Member

@tsullivan tsullivan commented Dec 9, 2019 •
edited
Loading

Closes

Release note:
Kibana Reporting is no longer compatible with POST URL snippets that were generated with Kibana 6.2 and below. Please use Kibana UI to re-generate the POST URL strings if you depend on these for automated PDF reports.

Separate release note:
Fixed an issue in Reporting where the type of report would sometimes not appear in the job listing.

@tsullivan tsullivan force-pushed the reporting/remove-6x-shims branch from bf4fe08 to e53d7b1 Compare December 10, 2019 19:25
@tsullivan tsullivan changed the title Remove Reporting compatibility shim [Reporting/Legacy] Remove reporting legacy job params compatibility shim Dec 10, 2019
@tsullivan tsullivan force-pushed the reporting/remove-6x-shims branch from e53d7b1 to 005faf5 Compare December 10, 2019 22:17
@tsullivan tsullivan mentioned this pull request Dec 12, 2019
Merged
1 task
@tsullivan tsullivan force-pushed the reporting/remove-6x-shims branch from 005faf5 to d2cbb51 Compare December 12, 2019 21:18
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 13, 2019

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan mentioned this pull request Jan 3, 2020
Closed
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented Jan 6, 2020

@elasticmachine merge upstream

@tsullivan tsullivan requested a review from joelgriffith January 6, 2020 19:24
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented Jan 6, 2020

@stacey-gammon had asked about the validity of removing the compatibility layers in this PR. There are removed log lines where the previous code was warning when the reporting flow would go through the compatibility layers:
https://github.com/elastic/kibana/pull/52539/files#diff-e96c331b2f0dd842137f82a04fde9839L77-L108

So to make it clear, the behavior being removed has been getting logged as deprecated in previous versions.

joelgriffith
joelgriffith approved these changes Jan 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+38 −724

APPROVED

@tsullivan tsullivan merged commit fef8485 into elastic:master Jan 6, 2020
@tsullivan tsullivan deleted the reporting/remove-6x-shims branch January 6, 2020 23:20
@tsullivan tsullivan removed the v7.6.0 label Jan 6, 2020
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented Jan 6, 2020

Removed 7.6.0 label: Do not backport this breaking change to 7.x

(may cause merge conflicts with future backports: sorry)

This was referenced Jan 7, 2020
Closed
Closed
Closed
@gchaps
Copy link
Copy Markdown
Contributor

gchaps commented Jan 24, 2020

@tsullivan Can you please add this change to the Breaking Changes in 8.0 doc?

@tsullivan tsullivan mentioned this pull request Jan 28, 2020
Merged
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented Jan 28, 2020

Sure: #56187

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 28, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Jan 29, 2020

test comment, ignore me

@tsullivan tsullivan mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobelb kobelb Awaiting requested review from kobelb

@stacey-gammon stacey-gammon Awaiting requested review from stacey-gammon

1 more reviewer

@joelgriffith joelgriffith joelgriffith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:breaking v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tsullivan @elasticmachine @gchaps @kibanamachine @jbudz @joelgriffith