Remove Kibana a11y guide in favor of EUI#52478
Closed
timroes wants to merge 1 commit intoelastic:masterfrom
Closed
Remove Kibana a11y guide in favor of EUI#52478timroes wants to merge 1 commit intoelastic:masterfrom
timroes wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Not sure if I'm in favor of this... I just updated the Kibana guide to do a few things:
|
Contributor
Author
|
Good points. I am still worried the more developers need to read, the less likely any of it will be read :D What would you think about moving the a11y testing guide into the development guide in the repository (beside the other testing paragraphs), and the HTML generation into the top level STYLEGUIDE.md file, since it shouldn't clutter it to much, and then instead link into the EUI styleguide? Or do you feel we'd still be losing to much in that case? |
Contributor
|
Sure, sounds like a good plan. I'm happy to consolidate our files. If you don't want to touch so much, I'm happy to take this as a to-do myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing the Kibana a11y style guide in favor of the new, way cooler EUI a11y styleguide.