Skip to content

[7.x] [ML] Anomaly Explorer: Deprecate explorer_controller (#51269)#51896

Merged
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-51269
Nov 29, 2019
Merged

[7.x] [ML] Anomaly Explorer: Deprecate explorer_controller (#51269)#51896
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-51269

Conversation

@walterra
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

The main goal of this PR is to get rid of explorer_controller.js to unblock the migration to react-router. Previously we already used rxjs observables to migrate away from angular events. Observables were used to trigger actions to manage the react component's state as well as AppState. This PR builds upon this previous work. The actions already were done similar to redux, now the use of observables has been extended to use scan (see rxjs docs) which allows us to transform the actions into state updates.
@walterra walterra added the backport This PR is a backport of another PR label Nov 28, 2019
@walterra walterra self-assigned this Nov 28, 2019
@walterra walterra added the :ml label Nov 28, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@walterra walterra merged commit f39c8d4 into elastic:7.x Nov 29, 2019
@walterra walterra deleted the backport/7.x/pr-51269 branch November 29, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR :ml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants