Skip to content

Tina heiligers backport/7.x/pr 50444#50974

Merged
TinaHeiligers merged 2 commits intoelastic:7.xfrom
TinaHeiligers:TinaHeiligers-backport/7.x/pr-50444
Nov 18, 2019
Merged

Tina heiligers backport/7.x/pr 50444#50974
TinaHeiligers merged 2 commits intoelastic:7.xfrom
TinaHeiligers:TinaHeiligers-backport/7.x/pr-50444

Conversation

@TinaHeiligers
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers commented Nov 18, 2019

Summary

Backports PR 50444 to 7.x

* [NP:Kibana:homeAPI] initializes a new plugin (WIP)

* Typing

* New plugin tutorials not needing server working

* Retains legacy tutorial registration and adds new route for new platform tutorial plugin registrations

* Adds comment on where to pre-register general non-plugin specific tutorials

* Converts TutorialsPlugin to TutorialsRegistry service in new Home plugin

* Changes call to location of registerTutorial in registerTutorials

* Adds console log for the home plugin that's returning an empty object

* Removes async from setup and start methods in the home plugin and the tutorials service

* Starts writing tests and creating mocks

* Adds basic tests for TutorialRegistry service

* Adds basic tests for TutorialRegistry service

* Adds test for route

* Adds mocks and tests for the home plugin

* Adds home plugin to security plugin and registers scoped tutorials service

* Removes incorrect addition to src core server

* Fixes type errors

* Deletes unused code

* Deletes duplicate golangMetricsSpecProvider registration

* Nests tutorials service in a tutorials key in the home plugin, changes api http routes for legacy platform and NP

* Changes url variable names
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@TinaHeiligers TinaHeiligers merged commit 6553d13 into elastic:7.x Nov 18, 2019
@TinaHeiligers TinaHeiligers deleted the TinaHeiligers-backport/7.x/pr-50444 branch November 18, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants