Skip to content

[7.x] [SIEM] Tests for search_after and bulk index (#50129)#50825

Merged
FrankHassanabad merged 1 commit intoelastic:7.xfrom
dhurley14:backport/7.x/pr-50129
Nov 16, 2019
Merged

[7.x] [SIEM] Tests for search_after and bulk index (#50129)#50825
FrankHassanabad merged 1 commit intoelastic:7.xfrom
dhurley14:backport/7.x/pr-50129

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* tests for detection engine get/put utils

* increases unit test code statement coverage to 100% for search_after / bulk index reindexer

* removes mockLogger declaration from individual test cases - clears mock counts before each test case runs so as to not accumulate method calls after each test case

* resets default paging size to 1000 - typo from when I was working through my tests

* updates tests after rebase with master

* fixes type check after fixing test from rebase with master

* removes undefined from maxSignals in type definition, updates tests with pure jest function implementations of logger and services - modifying only the return values or creating a mock implementation when necessary, removed some overlapping test cases

* fixes type issue

* replaces mock implementation with mock return value for unit test

* removes mock logger expected counts, just check if error logs are called, don't care about debug / warn etc.

* fixes more type checks after rebase with master
@dhurley14 dhurley14 added the backport This PR is a backport of another PR label Nov 15, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 5aa6eec into elastic:7.x Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants