Skip to content

Update dependency @elastic/charts to v15.0.1#50513

Closed
renovate[bot] wants to merge 11 commits intomasterfrom
renovate/@elasticcharts
Closed

Update dependency @elastic/charts to v15.0.1#50513
renovate[bot] wants to merge 11 commits intomasterfrom
renovate/@elasticcharts

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Nov 13, 2019 •
edited by nickofthyme
Loading

This PR contains the following updates:

Package Type Update Change
@elastic/charts dependencies major ^14.0.0 -> ^15.0.1

Release Notes

elastic/elastic-charts

v15.0.0

Compare Source

Code Refactoring
BREAKING CHANGES
  • GeometryId is now SeriesIdentifier. customSeriesColors prop on SeriesSpec which used to take a CustomSeriesColorsMap, now expects a CustomSeriesColors type. LegendItemListener now passes the SeriesIdentifier type as the first callback argument.
  • SpecId,AxisId, AnnotationId types are down-casted to a string type. The getSpecId, getAxisId and getAnnotationId methods still exist and but return just the same passed string until deprecated in a future version. The spec ids, previously id, axisId,annotationId etc are now aligned to use the same prop name: id. The chart rendering status data-ech-render-complete and data-ech-render-count is no more at the root level of the echChart div, but on its child element: echChartStatus. The Spec has two new private properties called chartType and specType.

v14.2.0

Compare Source

Code Refactoring
BREAKING CHANGES
  • GeometryId is now SeriesIdentifier. customSeriesColors prop on SeriesSpec which used to take a CustomSeriesColorsMap, now expects a CustomSeriesColors type. LegendItemListener now passes the SeriesIdentifier type as the first callback argument.
  • SpecId,AxisId, AnnotationId types are down-casted to a string type. The getSpecId, getAxisId and getAnnotationId methods still exist and but return just the same passed string until deprecated in a future version. The spec ids, previously id, axisId,annotationId etc are now aligned to use the same prop name: id. The chart rendering status data-ech-render-complete and data-ech-render-count is no more at the root level of the echChart div, but on its child element: echChartStatus. The Spec has two new private properties called chartType and specType.

v14.1.0

Compare Source

Features

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.6.0 v8.0.0 labels Nov 13, 2019
@renovate renovate bot requested a review from markov00 November 13, 2019 18:33
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2019

💔 Build Failed

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 5ae4f8e to e643dbc Compare November 22, 2019 19:36
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 22, 2019

💚 Build Succeeded

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from e643dbc to 075dbd2 Compare November 25, 2019 15:12
@renovate renovate bot changed the title Update dependency @elastic/charts to ^14.1.0 Update dependency @elastic/charts to ^14.2.0 Nov 25, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Nov 25, 2019

@elasticmachine merge upstream

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Nov 25, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 9710365 to 45dab2c Compare December 2, 2019 17:09
@renovate renovate bot changed the title Update dependency @elastic/charts to ^14.2.0 Update dependency @elastic/charts to v15 Dec 2, 2019
@nickofthyme nickofthyme added the renovate:major Renovate dependency update with major version updates label Dec 2, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2019

💔 Build Failed

@renovate renovate bot requested a review from a team December 2, 2019 23:12
@renovate renovate bot requested review from a team as code owners December 2, 2019 23:12
@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Dec 2, 2019 •
edited
Loading

@spalger I wanted to verify with you. I kept getting the following error when react hooks since we are currently using react as a dependency not a peerDependency in @elastic/charts. Hopefully, this is changed soon 👉elastic/elastic-charts#378

Uncaught Invariant Violation: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app

I was able to fix it by adding react to the yarn resolutions to force the version to match/use that of kibana but wanted to make sure this doesn't have any negative consequences that I'm not aware of, so long as all checks pass.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 3, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 3, 2019

💔 Build Failed

@nickofthyme nickofthyme changed the title Update dependency @elastic/charts to v15 Update dependency @elastic/charts to v15.0.1 Dec 3, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 3, 2019

💚 Build Succeeded

markov00
markov00 approved these changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the VRTs are slightly off because of a small change in the CanvasBBoxCalculator implementation added in the MobX -> Redux refactoring. I think we can approve all of them

@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Dec 3, 2019

@elastic/ml-ui & @elastic/logs-metrics-ui Could someone please review the elastic charts in your apps and make sure these changes don't cause a regression? Thanks!

peteharverson
peteharverson reviewed Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the ML charts, has the behavior changed to disable hover events? We now see a circle for line charts, where before we intentionally have no hover effect:

image

and for bar charts, the color of the hovered over bar lightens slightly:

image

Is there any way to disable this?

@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Dec 3, 2019

@markov00 have you noticed this with the redux changes? ☝️

@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Dec 4, 2019

@markov00 have you noticed this with the redux changes? ☝️

No, I haven't. Let me check and see if I forgot something during the refactoring

@markov00 markov00 mentioned this pull request Dec 4, 2019
Closed
2 tasks
@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Dec 4, 2019 •
edited
Loading

Ok, it's a regression. I opened an issue on our repo and I will fix that soon elastic/elastic-charts#478

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from baf0d08 to 993b6f1 Compare December 5, 2019 19:14
@nickofthyme nickofthyme force-pushed the renovate/@elasticcharts branch from 993b6f1 to 9a8b20f Compare December 5, 2019 20:20
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2019

💔 Build Failed

@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Dec 5, 2019

@peteharverson I updated the library with a patch for the hover issue. Could you please take another look when you have time?

Thanks

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2019

💚 Build Succeeded

@markov00 markov00 mentioned this pull request Dec 9, 2019
Closed
2 tasks
markov00
markov00 requested changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for elastic/elastic-charts#489 to be fixed to avoid the clipped rendering of the highlighter

@markov00 markov00 mentioned this pull request Dec 10, 2019
Merged
4 tasks
@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Dec 10, 2019

closing in favour of #52619

@markov00 markov00 closed this Dec 10, 2019
@renovate renovate bot deleted the renovate/@elasticcharts branch December 13, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickofthyme nickofthyme nickofthyme left review comments

@markov00 markov00 markov00 requested changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@angorayc angorayc Awaiting requested review from angorayc

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes renovate:major Renovate dependency update with major version updates renovate Renovate dependency update with major version updates v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@elasticmachine @spalger @nickofthyme @markov00 @peteharverson @weltenwort @renovate-bot