[ML] Adding cloud specific ML node warning#49861
Closed
jgowdyelastic wants to merge 11 commits intoelastic:masterfrom
Closed
[ML] Adding cloud specific ML node warning#49861jgowdyelastic wants to merge 11 commits intoelastic:masterfrom
jgowdyelastic wants to merge 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
@skearns64 please can we get your review on copy. Thx. |
Contributor
💔 Build Failed
|
Contributor
💔 Build Failed
|
Contributor
💔 Build Failed
|
500e0b9 to
826299e
Compare
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
…owdyelastic/kibana into adding-cloud-specific-ml-node-warning
Contributor
💔 Build Failed |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a link to the cloud deployment when there are no nodes and kibana is running on cloud.
Text in callout
Can be tested by adding some settings to yml files:
elasticsearch.yml
node.ml: falsekibana.yml
xpack.cloud.id: <supply your own cloud id>Also moves some code about:
removes
new_job_defaults.tsin favour of/services/ml_server_inforenames the function
loadNewJobDefaultstoloadMlServerInfoas more than just new job defaults are being loaded.new_job_defaultswas being deep linked to from other files, so it's best that it's moved to a common location. it also makes sense that the cloud checks to added to this file.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately