[7.x] Migrate ui/doc_title to New platform (#48121)#49265
Merged
pgayvallet merged 1 commit intoelastic:7.xfrom Oct 25, 2019
Merged
[7.x] Migrate ui/doc_title to New platform (#48121)#49265pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet merged 1 commit intoelastic:7.xfrom
Conversation
* create NP docTitle service and bridge LP to it Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * properly prefix the docTitle public types Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * update documentation Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * replace direct NP access with closure to avoid error when importing module in tests with no usages Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * remove arrow functions for doc generation Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * remove get$ from the api Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * remove apply param and excludeBase option Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * remove removed export Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * adapt legacy service to new api Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * add entry about docTitle in the migration guide Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * add link in migration guide Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * update generated doc Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * update chrome mock Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * update snapshots due to api change Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co> * remove ChromeDocTitleChange in favor of inline type Signed-off-by: pgayvallet <pierre.gayvallet@elastic.co>
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: