Closed
Conversation
Contributor
💔 Build Failed |
This was referenced Oct 23, 2019
16 tasks
Contributor
💔 Build FailedTo update your PR or re-run it, just comment with: |
Contributor
|
@kertal I'm reviewing everything with the FieldFormatter tag - whats the status of this PR? |
Member
Author
|
@kertal this was experimental and should be closed, but of course, having reactified field formatters would be neat :) |
Member
Author
|
Closing this because experimental |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the field formatters produce angular flavored html or plain text. This PR adds an options to format for usage in React. This removed the regression that e.g. links, images, audio formatted content was only displayed as text, and will also be used for our Data Grid implementation.
Fixes #48106
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately