Skip to content

[7.x] [SIEM] [Detection Engine] Adds stable alerting ids, more scripting for product testing, and more unit tests (#48471)#48580

Merged
FrankHassanabad merged 1 commit intoelastic:7.xfrom
FrankHassanabad:backport/7.x/pr-48471
Oct 18, 2019
Merged

[7.x] [SIEM] [Detection Engine] Adds stable alerting ids, more scripting for product testing, and more unit tests (#48471)#48580
FrankHassanabad merged 1 commit intoelastic:7.xfrom
FrankHassanabad:backport/7.x/pr-48471

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…r product testing, and more unit tests (elastic#48471)

* Adds stable alerting id's by using the alert params.
* Currently does a manual walk through of the alert params to find the stable id
* Updated all of the endpoints to take either of the two id's.
* Added several scripts to support performance testing ad-hoc such as `post_x_signals.sh`
* Added scripts to support converting from saved searches to alerts.
* Consolidated and fixed a lot of the backend types
* Added unit tests against the router endpoints
* elastic#47013

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@FrankHassanabad FrankHassanabad added the backport This PR is a backport of another PR label Oct 17, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 7ef04d4 into elastic:7.x Oct 18, 2019
@FrankHassanabad FrankHassanabad deleted the backport/7.x/pr-48471 branch October 18, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants