Skip to content

remove .required from shouldShowTelemetryOptIn prop#47940

Merged
Bamieh merged 1 commit intoelastic:masterfrom
Bamieh:telemetry/shouldShowTelemetryOptIn_not_required
Oct 11, 2019
Merged

remove .required from shouldShowTelemetryOptIn prop#47940
Bamieh merged 1 commit intoelastic:masterfrom
Bamieh:telemetry/shouldShowTelemetryOptIn_not_required

Conversation

@Bamieh
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh commented Oct 11, 2019

Closes #47912

@Bamieh Bamieh requested a review from a team October 11, 2019 10:17
@Bamieh Bamieh added the release_note:skip Skip the PR/issue when compiling release notes label Oct 11, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@Bamieh
Copy link
Copy Markdown
Contributor Author

Bamieh commented Oct 11, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh merged commit 0564396 into elastic:master Oct 11, 2019
@Bamieh Bamieh deleted the telemetry/shouldShowTelemetryOptIn_not_required branch October 11, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The prop shouldShowTelemetryOptIn is marked as required in Home, but its value is undefined.

3 participants