Skip to content

[7.x] Add scroll into view to avoid tooltip overlap (#47106)#47202

Merged
markov00 merged 2 commits intoelastic:7.xfrom
markov00:backport/7.x/pr-47106
Oct 4, 2019
Merged

[7.x] Add scroll into view to avoid tooltip overlap (#47106)#47202
markov00 merged 2 commits intoelastic:7.xfrom
markov00:backport/7.x/pr-47106

Conversation

@markov00
Copy link
Copy Markdown
Contributor

@markov00 markov00 commented Oct 3, 2019

Backports the following commits to 7.x:

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button.
The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.
@markov00 markov00 added the backport This PR is a backport of another PR label Oct 3, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 3, 2019

💔 Build Failed

13:36:08  ERROR: [Google Cloud Storage Plugin] No artifacts found matching pattern: target/kibana-*

@markov00
Copy link
Copy Markdown
Contributor Author

markov00 commented Oct 3, 2019

jenkins test this please

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@markov00
Copy link
Copy Markdown
Contributor Author

markov00 commented Oct 3, 2019

@elasticmachine update branch

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@markov00 markov00 merged commit 323165b into elastic:7.x Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants