[7.x] Add scroll into view to avoid tooltip overlap (#47106)#47202
Merged
markov00 merged 2 commits intoelastic:7.xfrom Oct 4, 2019
Merged
[7.x] Add scroll into view to avoid tooltip overlap (#47106)#47202markov00 merged 2 commits intoelastic:7.xfrom
markov00 merged 2 commits intoelastic:7.xfrom
Conversation
The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button. The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this please |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine update branch |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: