Skip to content

[7.x] Add request flyouts to JSON watch form and Threshold Watch edit form. (#43232)#46634

Merged
cjcenizal merged 1 commit intoelastic:7.xfrom
cjcenizal:backport/7.x/pr-43232
Sep 25, 2019
Merged

[7.x] Add request flyouts to JSON watch form and Threshold Watch edit form. (#43232)#46634
cjcenizal merged 1 commit intoelastic:7.xfrom
cjcenizal:backport/7.x/pr-43232

Conversation

@cjcenizal
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…elastic#43232)

* Refactor watch serialization logic into common serialization functions.
  - Refactor build helpers to accept specific arguments instead of the entire watch object, to make dependencies more obvious.
  - Move action models into common directory.
* Remove boom error reporting from action models because this is an unnecessary level of defensiveness since we control the UI that consumes this API.
* Convert tests from Mocha to Jest.
  - Remove mocks and fix assertions that depended upon mocked dependencies. These assertions were low-value because they tested implementation details.
  - Remove other assertions based upon implementation details.
* Remove serializeMonitoringWatch logic, since Monitoring doesn't use the create endpoint.
@cjcenizal cjcenizal added the backport This PR is a backport of another PR label Sep 25, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 2914360 into elastic:7.x Sep 25, 2019
@cjcenizal cjcenizal deleted the backport/7.x/pr-43232 branch September 25, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants