[7.x] [Console] Toward a more reactive data flow model (#45627)#45795
Merged
jloleysens merged 1 commit intoelastic:7.xfrom Sep 30, 2019
Merged
[7.x] [Console] Toward a more reactive data flow model (#45627)#45795jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens merged 1 commit intoelastic:7.xfrom
Conversation
Contributor
💚 Build Succeeded |
* First steps toward editor context (code not working here!)
* WiP, I broke some things
* Initial refactor to more react-like data flow
Introduced EditorContext with useReducer pattern (Read & Action)
Refactored old app startup ('./app.js')
Refactored most of input.js
Removed editor instances from services
* Clean up
* Better naming for es request callback
18699bc to
8f161a2
Compare
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: