[7.x] [Graph] Settings EUI-ification (#44587)#45639
Merged
flash1293 merged 1 commit intoelastic:7.xfrom Sep 13, 2019
Merged
Conversation
* create graph listing page * clean up app folder * remove inline loading menu * also add badge to workspace route * fix tests * fix graph spaces functional test * generate documentation for new breadcrumb property * fix test subject names * remove unused translations * start implementing save modal flow for Graph * fix spaces functional test * wip save modal * wip save modal * add and style save modal * add placeholder to description field * disable dirty check on breadcrumb navigation and fix delete function * reactify most of settings * improve onClick typing on breadcrumb * fix newline error and use new types in dashboard app controller * EUIify drilldown * EUIify drilldown * fix translation errors * fix i18n translation for real * fix icon and work on autoreplace template logic * use switch instead of checkbox * code review * fix i18n phrases * remove fragments * add KQL encoder to be able to drill down to discover * fix flyout overflow issue * delete old settings logic * remove obsolete files * fix tests * fix i18n phrase typo * fix most translations * start implementing review comments * continue implementing review * continue cleanup of settings forms * remove unnecessary max-width and add commentary * move to async syntax * clean up implementation * use description instead of title * work on settings form * fix snapshot * fix drilldown list * add tests for use_list_keys * rename stuff and add documentation * fix translatiojns * fix some rename references * start typing saving and loading * typing persistence stuff * adress review comments and set width for all save modals * type serializing logic * fix bug and improve typing * fix classname * wip * wip * add notes * style blacklist group * remove merge marker * improve icon rendering * wip * start refactoring * remove js implementation * remove js implementation * remove duplicate file * add some tests * Design cleanup * Fix SASS files * revert style fixes in app.js * implement todos * fix errors and prematurely enabling inspect panel * deselect icon after clicking again * fix types * make icon list accessible * clean up and add some more tests * improve number handling * fix deserialization * polishing drilldown-ui * rename types * clean up imports * fix tests * add handling for canEditDrillDowns setting * propagate changes to workspace client * align tabs with other elements
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: