Skip to content

[7.x] [Graph] Settings EUI-ification (#44587)#45639

Merged
flash1293 merged 1 commit intoelastic:7.xfrom
flash1293:backport/7.x/pr-44587
Sep 13, 2019
Merged

[7.x] [Graph] Settings EUI-ification (#44587)#45639
flash1293 merged 1 commit intoelastic:7.xfrom
flash1293:backport/7.x/pr-44587

Conversation

@flash1293
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* create graph listing page

* clean up app folder

* remove inline loading menu

* also add badge to workspace route

* fix tests

* fix graph spaces functional test

* generate documentation for new breadcrumb property

* fix test subject names

* remove unused translations

* start implementing save modal flow for Graph

* fix spaces functional test

* wip save modal

* wip save modal

* add and style save modal

* add placeholder to description field

* disable dirty check on breadcrumb navigation and fix delete function

* reactify most of settings

* improve onClick typing on breadcrumb

* fix newline error and use new types in dashboard app controller

* EUIify drilldown

* EUIify drilldown

* fix translation errors

* fix i18n translation for real

* fix icon and work on autoreplace template logic

* use switch instead of checkbox

* code review

* fix i18n phrases

* remove fragments

* add KQL encoder to be able to drill down to discover

* fix flyout overflow issue

* delete old settings logic

* remove obsolete files

* fix tests

* fix i18n phrase typo

* fix most translations

* start implementing review comments

* continue implementing review

* continue cleanup of settings forms

* remove unnecessary max-width and add commentary

* move to async syntax

* clean up implementation

* use description instead of title

* work on settings form

* fix snapshot

* fix drilldown list

* add tests for use_list_keys

* rename stuff and add documentation

* fix translatiojns

* fix some rename references

* start typing saving and loading

* typing persistence stuff

* adress review comments and set width for all save modals

* type serializing logic

* fix bug and improve typing

* fix classname

* wip

* wip

* add notes

* style blacklist group

* remove merge marker

* improve icon rendering

* wip

* start refactoring

* remove js implementation

* remove js implementation

* remove duplicate file

* add some tests

* Design cleanup

* Fix SASS files

* revert style fixes in app.js

* implement todos

* fix errors and prematurely enabling inspect panel

* deselect icon after clicking again

* fix types

* make icon list accessible

* clean up and add some more tests

* improve number handling

* fix deserialization

* polishing drilldown-ui

* rename types

* clean up imports

* fix tests

* add handling for canEditDrillDowns setting

* propagate changes to workspace client

* align tabs with other elements
@flash1293 flash1293 added the backport This PR is a backport of another PR label Sep 13, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@flash1293 flash1293 merged commit 72a8ded into elastic:7.x Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants