Skip to content

[7.x] [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (#44943)#45405

Merged
poffdeluxe merged 2 commits intoelastic:7.xfrom
poffdeluxe:backport/7.x/pr-44943
Sep 12, 2019
Merged

[7.x] [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (#44943)#45405
poffdeluxe merged 2 commits intoelastic:7.xfrom
poffdeluxe:backport/7.x/pr-44943

Conversation

@poffdeluxe
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@poffdeluxe poffdeluxe added the backport This PR is a backport of another PR label Sep 11, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

…ert to typescript (elastic#44943)

* i18n work on workpad header and a few header ctas

* Convert WorkpadHeader to typescript

* String ordering cleanup

* Addressing some feedback

* Adding state

* lint

* Shortcut type refactor

* Revert "Shortcut type refactor"

This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650.

* Using new State type

* Removing unused type

* Updating state type
@poffdeluxe poffdeluxe force-pushed the backport/7.x/pr-44943 branch from 3d6ee68 to a273621 Compare September 11, 2019 19:55
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Sep 11, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@poffdeluxe poffdeluxe merged commit 69878a5 into elastic:7.x Sep 12, 2019
@poffdeluxe poffdeluxe deleted the backport/7.x/pr-44943 branch September 12, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants