[7.x] [ML] Fix focus chart updating. (#45146)#45242
Merged
walterra merged 1 commit intoelastic:7.xfrom Sep 10, 2019
Merged
Conversation
- Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false. - Triggers the overall loading indicator when the focus chart reloads - Fixes to pass in values for the progress bar as numbers instead of strings.
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: