Skip to content

Deprecate kibana_user and kibana_dashboard_only_user roles#45045

Closed
legrego wants to merge 30 commits intoelastic:masterfrom
legrego:security/deprecate-kibana-roles
Closed

Deprecate kibana_user and kibana_dashboard_only_user roles#45045
legrego wants to merge 30 commits intoelastic:masterfrom
legrego:security/deprecate-kibana-roles

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented Sep 6, 2019

Summary

Updates the Role Management and User Management screens to support the concept of deprecated roles.

Tasks

  • Initial UI changes
  • Design review
  • Copy review
  • Testing

Role Management Grid

Alert icon instead of checkbox for deprecated roles:
image

Viewing Deprecated Role

image

User grid page

Color deprecated roles with the warning color:
image

Editing user with deprecated role:

image

image

Companion ES PR: elastic/elasticsearch#46456

Resolves #25722

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Jan 10, 2020

@elastic/kibana-design I'll be resurrecting this PR fairly soon. Would love to get your feedback on my proposal. I'm also open to any ideas you have, this was just my first attempt!

@legrego legrego force-pushed the security/deprecate-kibana-roles branch from 2024ae4 to 597c471 Compare January 31, 2020 18:58
@streamich streamich added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Feb 7, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-security (Team:Security)

@andreadelrio
Copy link
Copy Markdown
Contributor

@legrego here's some suggestions for the User grid page:

  • Increase width of Roles column in table.
  • Print one role per line, remove commas, keep roles text in blue, alert icon is still yellow. I think having a yellow icon next to blue text helps bring attention to the icon as it pops out because of the contrast.
  • Increase gutter in Status column (this change is not shown in the screenshot below)

This will result in:

MacBook Pro - 2

vs before

localhost_5601_app_kibana(Laptop with HiDPI screen) (2)

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Feb 10, 2020

Thanks @andreadelrio, I'll incorporate your suggestions!

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Feb 11, 2020

Superseded by #57209

@legrego legrego closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce kibana_admin role, deprecate kibana_user and kibana_dashboard_only_userroles

5 participants