Skip to content

[7.4] [SIEM] Remove deprecation warning from momentJS test (#44732)#44740

Merged
FrankHassanabad merged 1 commit intoelastic:7.4from
FrankHassanabad:backport/7.4/pr-44732
Sep 4, 2019
Merged

[7.4] [SIEM] Remove deprecation warning from momentJS test (#44732)#44740
FrankHassanabad merged 1 commit intoelastic:7.4from
FrankHassanabad:backport/7.4/pr-44732

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.4:

## Summary

Removes a deprecation warning from a unit test when it passed invalid values to momentJS

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@FrankHassanabad FrankHassanabad added the backport This PR is a backport of another PR label Sep 4, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 6d9c588 into elastic:7.4 Sep 4, 2019
@FrankHassanabad FrankHassanabad deleted the backport/7.4/pr-44732 branch September 4, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants