Skip to content

[Reporting] Fix headless browser console log capturing#44056

Closed
tsullivan wants to merge 1 commit intoelastic:masterfrom
tsullivan:reporting/fix-console-logging
Closed

[Reporting] Fix headless browser console log capturing#44056
tsullivan wants to merge 1 commit intoelastic:masterfrom
tsullivan:reporting/fix-console-logging

Conversation

@tsullivan
Copy link
Copy Markdown
Member

Summary

Replaces #43318

This PR fixes the Reporting plugin's capturing of headless browser console logs. The previous code could be specific to PhantomJS, but didn't work very well with Chromium (errors only were logged)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@tsullivan
Copy link
Copy Markdown
Member Author

close in favor of #44359

@tsullivan tsullivan closed this Aug 30, 2019
@tsullivan tsullivan deleted the reporting/fix-console-logging branch September 23, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants