[Reporting] Fix headless browser console log capturing#44056
Closed
tsullivan wants to merge 1 commit intoelastic:masterfrom
Closed
[Reporting] Fix headless browser console log capturing#44056tsullivan wants to merge 1 commit intoelastic:masterfrom
tsullivan wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
bf9b145 to
6c51872
Compare
7 tasks
Contributor
💔 Build Failed |
Member
Author
|
close in favor of #44359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #43318
This PR fixes the Reporting plugin's capturing of headless browser console logs. The previous code could be specific to PhantomJS, but didn't work very well with Chromium (errors only were logged)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers