[7.x] [SIEM] Toggle Column / Code Coverage and Cypress (#42766)#43166
Merged
andrew-goldstein merged 1 commit intoelastic:7.xfrom Aug 13, 2019
Merged
[7.x] [SIEM] Toggle Column / Code Coverage and Cypress (#42766)#43166andrew-goldstein merged 1 commit intoelastic:7.xfrom
andrew-goldstein merged 1 commit intoelastic:7.xfrom
Conversation
## Features - A `Toggle column` checkbox for adding / removing fields in the timeline offers an alternative to drag and drop in an expanded event:  The behavior of the `Toggle field` checkbox in the expanded event is the same as the checkboxes that appear in the timeline _Fields Browser_. ## Fixes - Pinned timeline events now use a "filled" styling when pinned instead of rotation, and unpinned events have a higher contrast in dark mode: Before:  After (unpinned):  After (pinned):  - Fixed an issue where the `Copy to Clipboard` icon rendered incorrectly (too small, and not the right color): Before:  After:  - Fixed an issue where a previously invisible control became visible and occupied additonal row space in the timeline: Before:  After:  - Fixed an issue where the timeline Fields Browser Overlaps Column Headers Before:  After:  ## Code Coverage and Cypress Tests - This PR increases the `jest` unit test coverage for the _Fields Browser_, and introduces `Cypress` tests for it - Added new `Cypress` test helpers, configuration, and test refactorings to support running smoke tests against remote Kibana instances, including [Elastic Cloud](https://www.elastic.co/cloud) - Refactored some `Cypress` tests to speed them up and reduce flakyness elastic/siem-team#380 elastic/siem-team#431 elastic/siem-team#432 elastic/siem-team#433 elastic/siem-team#434 elastic/siem-team#435
f6a7baa to
3c6fbf1
Compare
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: