Skip to content

use inspector types in data plugin#42615

Closed
lizozom wants to merge 1 commit intoelastic:masterfrom
lizozom:newplatform/data-plugin/inspector-deps
Closed

use inspector types in data plugin#42615
lizozom wants to merge 1 commit intoelastic:masterfrom
lizozom:newplatform/data-plugin/inspector-deps

Conversation

@lizozom
Copy link
Copy Markdown
Contributor

@lizozom lizozom commented Aug 5, 2019

Summary

Re-exported types from adapters folder to use them in data plugin.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested review from flash1293 and streamich August 5, 2019 16:03
@lizozom lizozom self-assigned this Aug 5, 2019
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes Feature:Inspector Inspector infrastructure and implementations Feature:New Platform v7.4.0 v8.0.0 labels Aug 5, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this style of exporting doesn't work on a unit test level. Plus there is a conflicting PR up here: #42337 - maybe we should solve this problem over there?

@lizozom
Copy link
Copy Markdown
Contributor Author

lizozom commented Aug 6, 2019

@flash1293 totally!

@lizozom lizozom mentioned this pull request Aug 6, 2019
7 tasks
@lizozom
Copy link
Copy Markdown
Contributor Author

lizozom commented Aug 6, 2019

Conflicts with #42337
Closing

@lizozom lizozom closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Inspector Inspector infrastructure and implementations Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants