Skip to content

Disables response logging as a default#42353

Merged
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:no-response-logging
Aug 12, 2019
Merged

Disables response logging as a default#42353
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:no-response-logging

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

Previously, if any of the following were true, we would log HTTP responses.

  • logging.json was set
  • logging.dest was set
  • TTY was detected

The logging format should not dictate what is logged

Release Note: Responses are never logged by default. Previously, responses would be logged if either logging.json was true, logging.dest was specified, or a TTY was detected. To restore the previous behavior set logging.events.response=*` in kibana.yml.

Previously, if any of the following were true, we would log HTTP responses.
- `logging.json` was set
- `logging.dest` was set
- `TTY` was detected

The logging format should not dictate what is logged

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@tylersmalley
Copy link
Copy Markdown
Member Author

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@tylersmalley tylersmalley merged commit 372b79e into elastic:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants