Skip to content

[7.x] Implement wanted error handling for alerting and actions (#41917)#42255

Merged
mikecote merged 2 commits intoelastic:7.xfrom
mikecote:backport/7.x/pr-41917
Jul 30, 2019
Merged

[7.x] Implement wanted error handling for alerting and actions (#41917)#42255
mikecote merged 2 commits intoelastic:7.xfrom
mikecote:backport/7.x/pr-41917

Conversation

@mikecote
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@mikecote mikecote added the backport This PR is a backport of another PR label Jul 30, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

mikecote added 2 commits July 30, 2019 16:56
)

* Implement wanted error handling

* Cleanup

* Add retry logic to actions

* Leverage startedAt from task manager

* Fix broken jest tests

* Add missing unit test

* Add unit tests for getRetry

* Add test for rate limit

* Remove fake timers

* Don't retry errors by default for actions unless the proper result format is returned with status: error

* Don't retry unless attribute specified

* Fix tests
@mikecote mikecote force-pushed the backport/7.x/pr-41917 branch from e0920c6 to d608f00 Compare July 30, 2019 20:56
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit 0a861ca into elastic:7.x Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants