Skip to content

[7.x] Remove sort, move, and remove buttons from Context app's table header…#42082

Merged
Bargs merged 2 commits intoelastic:7.xfrom
Bargs:backport/42026/7.x
Jul 26, 2019
Merged

[7.x] Remove sort, move, and remove buttons from Context app's table header…#42082
Bargs merged 2 commits intoelastic:7.xfrom
Bargs:backport/42026/7.x

Conversation

@Bargs
Copy link
Copy Markdown
Contributor

@Bargs Bargs commented Jul 26, 2019

… (#42026)

Prior to #41259 we intentionally did not show the sort, move, and remove column buttons in the doc table in the Context app. Context doesn't pass in handlers for these actions and in the old angular directive we conditionally showed the buttons depending on whether those handlers were passed in. So in this PR I've simply mimicked that behavior in the new React component.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

…elastic#42026)

Prior to elastic#41259 we intentionally did not show the sort, move, and remove column buttons in the doc table in the Context app. Context doesn't pass in handlers for these actions and in the old angular directive we conditionally showed the buttons depending on whether those handlers were passed in. So in this PR I've simply mimicked that behavior in the new React component.
@Bargs Bargs added the backport This PR is a backport of another PR label Jul 26, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@Bargs Bargs merged commit 6bdeff1 into elastic:7.x Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants