ML Kibana privileges opt-in using kibana.yml#40073
ML Kibana privileges opt-in using kibana.yml#40073kobelb wants to merge 13 commits intoelastic:masterfrom
Conversation
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
| const isAllowedCustomizations = | ||
| allowedPrivileges[record.spacesIndex].base.privileges.length > 1; | ||
| const featureEntries = Object.values(allowedPrivileges[record.spacesIndex].feature); | ||
| const isAllowedCustomizations = featureEntries.some(entry => { |
There was a problem hiding this comment.
Without this change, if I gave the user global all and then a custom set of privileges at a space granting access to ML, it'd show "All" for the space specific privileges:
| return ( | ||
| <PrivilegeDisplay | ||
| explanation={basePrivilege} | ||
| explanation={showCustomize ? undefined : basePrivilege} |
There was a problem hiding this comment.
Without this change, if I gave the user global all and then a custom set of privileges at a space granting access to ML, it'd show "Custom" with a lock even though it's truly just Custom:
| if ( | ||
| hasAssignedFeaturePrivileges(form) || | ||
| explanation.actualPrivilege === NO_PRIVILEGE_VALUE || | ||
| form.base.length === 0 || |
There was a problem hiding this comment.
Without this change, if I gave the user global all and then created a new entry for the default space, the drop-down would default to "All" because this was the "actual privilege" which it inherited globally. Where-as elsewhere we default to "Custom" whenever we can:
💔 Build Failed |
💚 Build Succeeded |
|
ACK, will look today |
legrego
left a comment
There was a problem hiding this comment.
These changes seem reasonable enough to avoid rearchitecting the privilege calculator.
We're changing an assumption with this PR -- before, features could have either reserved or regular privileges, but never both. Now we have features with both..this is obviously expected as part of this effort, but I'm trying to think of any other places where this assumption is important...I can't think of anything right now, but I'll update if I come across anything else.
|
Thanks @legrego, I'm gonna pull these changes out into another PR and add the necessary tests. |
💔 Build Failed |
💔 Build Failed |
No description provided.