Per panel time range by stacey-gammon · Pull Request #39937 · elastic/kibana

stacey-gammon · 2019-06-28T19:14:57Z

Summary

Each panel on a dashboard can now be configured to show a custom time range, independent from the global one. Just go to the menu options and select Customize time range. If the panel's time range is different than what is showing in the global time picker, it will contain a visible badge showing the date.

fixes #17776 and #3578

elasticmachine · 2019-06-28T20:17:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-08T20:13:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Conky5 · 2019-07-08T20:33:01Z

retest

elasticmachine · 2019-07-08T21:48:09Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-12T19:52:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-12T20:08:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-12T21:09:15Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-13T00:59:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-13T14:44:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-13T16:19:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-15T21:44:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-07-15T21:48:47Z

Just need the pretty print functionality from EUI and this is ready to GO! woot!

elasticmachine · 2019-07-25T21:05:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-07-26T12:37:21Z

failed on maps app documents source search hits filter by extent should handle geo_shape filtering with extents that cross antimeridian

going to pull in master and retry.

…me-range-per-panel

elasticmachine · 2019-07-26T13:38:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cchaos

Thanks for making those changes, though I'm still seeing an issue with the flex group layout of the modal buttons.

cchaos · 2019-07-26T13:38:31Z

x-pack/legacy/plugins/advanced_ui_actions/public/customize_time_range_modal.tsx

+        </EuiModalHeader>
+
+        <EuiModalBody>
+          {' '}


Why is there an empty space here?

I do not know, I remove all the weird spaces in this file.

cchaos · 2019-07-26T13:40:14Z

x-pack/legacy/plugins/advanced_ui_actions/public/customize_time_range_modal.tsx

+                  )}
+                </EuiButtonEmpty>
+
+                <EuiButton


This flex group stuff still needs to be cleaned up. There's too many nested FlexGroups. You can use the code above for the layout.

…me-range-per-panel

stacey-gammon · 2019-07-29T14:10:01Z

@AlonaNadler - good call, I missed that the recent time ranges were different. It's now pulling from advanced settings so they should match.

elasticmachine · 2019-07-29T15:13:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cchaos · 2019-07-29T15:50:10Z

I'm noticing that if the panels get really skinny, the time range badge can become completely invisible.

I'll have to give you a PR that will allow the panel title to wrap its contents.

Another quick question, should user's be able to customize time ranges when not in edit mode?

stacey-gammon · 2019-07-29T15:58:21Z

Ah, awesome, good catch re: the wrapping.

Another quick question, should user's be able to customize time ranges when not in edit mode?

Yep, that is intentional, so a user who doesn't have edit rights can still temporarily see the different time range, it just won't be saved with the panel like it would in edit mode. If that seems too confusing we can talk about removing it, but I'm pretty sure @AlonaNadler thinks users will find that functionality useful.

…me-range-per-panel

cchaos · 2019-07-29T16:22:28Z

PR4U: stacey-gammon#10

Yep, that is intentional

I think it's fine to allow this in non-edit mode, I just think it's currently unclear that this won't be saved with the dashboard. But I'm not really sure how to mitigate that.

elasticmachine · 2019-07-29T17:00:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…me-range-per-panel

stacey-gammon · 2019-07-31T14:16:50Z

Ping @ppisljar or @streamich for review. :) (I promise @streamich I'm going to review your inspector -> NP today!)

elasticmachine · 2019-07-31T15:27:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

very nice! i have some small comments but mostly LGTM
tested on chrome linux

x-pack/legacy/plugins/advanced_ui_actions/public/custom_time_range_action.tsx

x-pack/legacy/plugins/advanced_ui_actions/public/custom_time_range_badge.tsx

ppisljar · 2019-08-05T08:40:04Z

x-pack/legacy/plugins/advanced_ui_actions/public/shim/plugin.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { PluginInitializerContext, CoreStart } from 'src/core/public';


this is not shim and should be moved one level up i think @streamich ?

x-pack/legacy/plugins/advanced_ui_actions/public/index.ts

…me-range-per-panel

cchaos · 2019-08-05T13:28:28Z

Hey @stacey-gammon Did you see my PR I made for you that will fix the wrapping header? stacey-gammon#10

elasticmachine · 2019-08-05T14:17:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon mentioned this pull request Jun 28, 2019

Meta: Custom time ranges per panel #17776

Closed

7 tasks

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 3497eed to 68c3519 Compare July 8, 2019 19:16

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch 4 times, most recently from be93ca1 to 264c904 Compare July 12, 2019 19:52

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 264c904 to 615669e Compare July 12, 2019 23:47

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 615669e to 09ee01f Compare July 13, 2019 13:46

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 09ee01f to 1460884 Compare July 13, 2019 15:18

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 1460884 to 1a7f7f0 Compare July 15, 2019 20:36

Per panel time range

14ed5b5

stacey-gammon force-pushed the 2019-06-28-time-range-per-panel branch from 1a7f7f0 to 14ed5b5 Compare July 24, 2019 14:52

stacey-gammon marked this pull request as ready for review July 24, 2019 14:53

stacey-gammon requested review from lizozom and ppisljar July 24, 2019 14:54

stacey-gammon added v7.4.0 release_note:enhancement v8.0.0 labels Jul 24, 2019

Stacey Gammon added 2 commits July 25, 2019 15:56

fix: type errors

a874332

put xpack i18n links back in right place

9ccd033

Merge branch 'master' of github.com:elastic/kibana into 2019-06-28-ti…

28aef75

…me-range-per-panel

cchaos suggested changes Jul 26, 2019

View reviewed changes

Stacey Gammon added 3 commits July 29, 2019 09:52

Merge branch 'master' of github.com:elastic/kibana into 2019-06-28-ti…

ab3f7dd

…me-range-per-panel

Fix flex items, remove spaces

bbf4b8d

use right string for detecting input control vis types

36c3542

Merge branch 'master' of github.com:elastic/kibana into 2019-06-28-ti…

eab24fc

…me-range-per-panel

Merge branch 'master' of github.com:elastic/kibana into 2019-06-28-ti…

94e50da

…me-range-per-panel

ppisljar approved these changes Aug 5, 2019

View reviewed changes

Stacey Gammon added 4 commits August 5, 2019 08:48

Merge branch 'master' of github.com:elastic/kibana into 2019-06-28-ti…

376db13

…me-range-per-panel

delete empty file

f47c8a4

remove unneccessary checks

b72106b

hide time range override action for markdown vis

ace9253

stacey-gammon mentioned this pull request Aug 12, 2019

switch to icon type string instead of node #43111

Merged

stacey-gammon closed this Aug 14, 2019

cchaos mentioned this pull request Sep 25, 2019

[Embeddables] Time range per panel design fixes #46630

Merged

2 tasks

Conversation

stacey-gammon commented Jun 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jun 28, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 8, 2019

💔 Build Failed

Uh oh!

Conky5 commented Jul 8, 2019

Uh oh!

elasticmachine commented Jul 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 15, 2019

💚 Build Succeeded

Uh oh!

stacey-gammon commented Jul 15, 2019

Uh oh!

elasticmachine commented Jul 25, 2019

💔 Build Failed

Uh oh!

stacey-gammon commented Jul 26, 2019

Uh oh!

elasticmachine commented Jul 26, 2019

💚 Build Succeeded

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos Jul 26, 2019

Choose a reason for hiding this comment

Uh oh!

stacey-gammon Jul 29, 2019

Choose a reason for hiding this comment

Uh oh!

cchaos Jul 26, 2019

Choose a reason for hiding this comment

Uh oh!

stacey-gammon commented Jul 29, 2019

Uh oh!

elasticmachine commented Jul 29, 2019

💚 Build Succeeded

Uh oh!

cchaos commented Jul 29, 2019

Uh oh!

stacey-gammon commented Jul 29, 2019

Uh oh!

cchaos commented Jul 29, 2019

Uh oh!

elasticmachine commented Jul 29, 2019

💚 Build Succeeded

Uh oh!

stacey-gammon commented Jul 31, 2019

Uh oh!

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

stacey-gammon commented Jun 28, 2019 •

edited

Loading