[Logs UI] Add single phrase highlighting by Kerry350 · Pull Request #39569 · elastic/kibana

Kerry350 · 2019-06-25T11:17:08Z

Summary

This PR adds the ability to highlight a phrase in the logs displayed in the Logs UI. The "Highlights" button in the toolbar opens a popover that allows changing and clearing of a single phrase for now.

partly implements #22916

Known Limitations

Highlighting in timeline: To get this PR ready for review as quickly as possible, this will be implemented in a follow-up PR. ([Logs UI] Show highlighted log entries in the minimap #40745)
Jumping to previous/next highlight: For the same reasons, this will be implemented in a separate follow-up PR. ([Logs UI] Allow for jumping to the previous and next highlight #40010)
Single phrase: The UI only allows for a single phrase to be highlighted. It can be extended to multiple phrases when the semantics of potentially overlapping highlights have been discussed.

Screenshots

Checklist

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~ this will be handled in a separate PR
~~Unit or functional tests were updated or added to match the most common scenarios~~ functional tests will be added in a separate PR
This was checked for keyboard-only and screenreader accessibility

elasticmachine · 2019-06-25T11:37:57Z

Pinging @elastic/infra-logs-ui

elasticmachine · 2019-06-25T12:15:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-25T18:31:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-25T19:28:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…nto 22916-log-highlighting

elasticmachine · 2019-06-26T14:35:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-26T15:44:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-27T11:35:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…hting

elasticmachine · 2019-07-02T19:22:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

weltenwort · 2019-07-02T19:46:26Z

We're now using the EUI accent color for the button indicator as well as the highlights.

@formgeist @jasonrhodes any further thoughts on your reviews?

formgeist · 2019-07-02T19:48:56Z

I'm good with leaving the notification badge for when we support multiple terms. And the accent for the indicator and highlights looks amazing 😍Thanks for getting this in!

jasonrhodes · 2019-07-02T19:50:06Z

@weltenwort one question: I notice that highlight_query is the same as the search query as far as the multi_match block goes. Is there a reason to specify highlight_query if it's the same? Is it that it leaves out the date range so we get more results for next/prev or something like that?

weltenwort · 2019-07-02T19:55:50Z

Unless I made a mistake, the search query should be a conjunction of the filter and the highlight query. But within that result set we only want to apply the highlight query, because we don't want to highlight the filter terms.

jasonrhodes · 2019-07-02T20:02:01Z

Unless I made a mistake, the search query should be a conjunction of the filter and the highlight query. But within that result set we only want to apply the highlight query, because we don't want to highlight the filter terms.

👍 I added a filter in the query bar and now I see the difference. Thanks!

jasonrhodes

Great work here and great job paring this down to a useful MVP! 👏

jasonrhodes · 2019-07-02T20:12:21Z

Something I just noticed:

Seems like maybe the first one isn't highlighted at least in this example…

weltenwort · 2019-07-02T20:41:25Z

Does it stay that way when you clear and re-enter the highlighting term?

jasonrhodes · 2019-07-02T20:49:58Z

Does it stay that way when you clear and re-enter the highlighting term?

Yes, if I click the trash can and re-enter the term, the same thing happens.

elasticmachine · 2019-07-02T21:32:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jasonrhodes

Great success! (This time on the correct PR)

weltenwort · 2019-07-02T21:40:44Z

carried on winds
the hope outlasts dusk?
retest

weltenwort · 2019-07-02T21:41:48Z

since when is jenkins haiku immune?

jenkins, test this again

elasticmachine · 2019-07-02T22:47:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

This PR adds the ability to highlight a phrase in the logs displayed in the Logs UI. The "Highlights" button in the toolbar opens a popover that allows changing and clearing of a single phrase for now. partly implements elastic#22916

Backports the following commits to 7.x: - [Logs UI] Add single phrase highlighting (#39569)

elasticmachine · 2019-07-12T09:37:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Commit to allow opening the PR

bd2e87a

Kerry350 assigned Kerry350 and weltenwort Jun 25, 2019

weltenwort added :Logs UI Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 25, 2019

Kerry350 and others added 7 commits June 25, 2019 13:37

Add start of the highlights menu

c54da94

Add terms input

0b7420a

Add a container for highlights state

a762d02

Start to hook up highlights state effects, and Bridge with Redux

494604c

Move highlighted logs to a separate graphql field

3f2bc2e

Add highlights argument to unit tests

be180ea

Add initial draft of a log highlights hook

abb640b

Kerry350 added 4 commits June 26, 2019 11:55

Finish hooking up hook state ready for GraphQL query

ad207ea

Merge branch '22916-log-highlighting' of github.com:Kerry350/kibana i…

0a43161

…nto 22916-log-highlighting

Take startKey and endKey from overall collection of log entries

87347d3

Add sourceVersion

e4b95f6

Fetch the data

b778172

weltenwort added 2 commits June 27, 2019 12:16

Use columns ids instead of column indices

653d468

merge highlights into stream WIP

1302ebd

Kerry350 and others added 3 commits June 27, 2019 13:09

Merge remote-tracking branch 'upstream/master' into 22916-log-highlig…

9565afd

…hting

Add highlighting for the message column type

2a96ef4

Use the serialized filter query

9c03ced

This comment has been minimized.

Sign in to view

jasonrhodes approved these changes Jul 2, 2019

View reviewed changes

Take exclusive start time into account

950bbba

jasonrhodes approved these changes Jul 2, 2019

View reviewed changes

weltenwort merged commit de5e653 into elastic:master Jul 2, 2019

weltenwort mentioned this pull request Jul 2, 2019

[7.x] [Logs UI] Add single phrase highlighting (#39569) #40221

Merged

weltenwort added a commit that referenced this pull request Jul 2, 2019

[7.x] [Logs UI] Add single phrase highlighting (#39569) (#40221)

f68b5a1

Backports the following commits to 7.x: - [Logs UI] Add single phrase highlighting (#39569)

jasonrhodes added v7.3.0 in-test-plan labels Jul 5, 2019

simianhacker mentioned this pull request Jul 5, 2019

[Log UI] Highlighting doesn't appear to be working #40452

Closed

weltenwort mentioned this pull request Jul 9, 2019

[Logs UI] Document simple phrase highlighting #40596

Closed

weltenwort added the v8.0.0 label Jul 9, 2019

jasonrhodes added Feature:Logs UI Logs UI feature and removed :Logs UI labels Jul 16, 2019

weltenwort mentioned this pull request Sep 23, 2019

[Logs UI] View in context #40808

Closed

Conversation

Kerry350 commented Jun 25, 2019 • edited by weltenwort Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Known Limitations

Screenshots

Checklist

Uh oh!

elasticmachine commented Jun 25, 2019

Uh oh!

elasticmachine commented Jun 25, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 25, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 25, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jun 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jun 27, 2019

💔 Build Failed

Uh oh!

This comment has been minimized.

elasticmachine commented Jul 2, 2019

💚 Build Succeeded

Uh oh!

weltenwort commented Jul 2, 2019

Uh oh!

formgeist commented Jul 2, 2019

Uh oh!

jasonrhodes commented Jul 2, 2019

Uh oh!

weltenwort commented Jul 2, 2019

Uh oh!

jasonrhodes commented Jul 2, 2019

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

jasonrhodes commented Jul 2, 2019

Uh oh!

weltenwort commented Jul 2, 2019

Uh oh!

jasonrhodes commented Jul 2, 2019

Uh oh!

elasticmachine commented Jul 2, 2019

💔 Build Failed

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort commented Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weltenwort commented Jul 2, 2019

Uh oh!

elasticmachine commented Jul 2, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 12, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kerry350 commented Jun 25, 2019 •

edited by weltenwort

Loading

weltenwort commented Jul 2, 2019 •

edited

Loading