[Vis: Default editor] EUIficate IP Ranges#36896
Merged
maryia-lapata merged 23 commits intoelastic:masterfrom Jun 4, 2019
Merged
[Vis: Default editor] EUIficate IP Ranges#36896maryia-lapata merged 23 commits intoelastic:masterfrom
maryia-lapata merged 23 commits intoelastic:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-app |
29 tasks
Contributor
💚 Build Succeeded |
10 tasks
Contributor
Author
|
@kertal I created a PR with fix for not clickable button with svg: elastic/eui#1985 |
Contributor
💚 Build Succeeded |
wylieconlon
approved these changes
May 31, 2019
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Functionality LGTM, but I'd like more type safety in the spot I mentioned. We should be avoiding any types.
|
|
||
| export type InputModel = | ||
| | InputModelBase & { [model: string]: InputItem } | ||
| | InputModelBase & InputItem; |
Contributor
There was a problem hiding this comment.
This type is currently meaningless for the reason above- the union of [key: string]: any and anything else allows all values.
Contributor
Author
There was a problem hiding this comment.
I unified Mask and FromTo models and updated InputModel definition. Please take a look.
kertal
requested changes
Jun 3, 2019
Member
kertal
left a comment
There was a problem hiding this comment.
There seems to be a problem at CIDR mask validation, 0.0.0.0/123d validates correctly
Contributor
💚 Build Succeeded |
Contributor
Author
@kertal thank you for noticing, it was a bug in initial version of |
Contributor
💚 Build Succeeded |
kertal
approved these changes
Jun 3, 2019
Member
kertal
left a comment
There was a problem hiding this comment.
Thank you for the fixes, Code LGTM, tested in Chrome / Firefox. We should test it again in Safari/IE11 when your EUI fix is released
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 4, 2019
* Create IpRangeType and IpRanges controls * Add validation * Refactoring * Add behavior when discarding changes * Refactoring: create common input list * Remove old template * Move add btn to input_list, add placeholder * Remove unused directives * Remove unused translations * Refactoring * Use EuiButtonGroup instead of toggle button * Update options ids, add aria-labels * Remove unused translations * Update mask model, update TS, update aria labels * Add validation for CIRD mask
maryia-lapata
added a commit
that referenced
this pull request
Jun 4, 2019
* Create IpRangeType and IpRanges controls * Add validation * Refactoring * Add behavior when discarding changes * Refactoring: create common input list * Remove old template * Move add btn to input_list, add placeholder * Remove unused directives * Remove unused translations * Refactoring * Use EuiButtonGroup instead of toggle button * Update options ids, add aria-labels * Remove unused translations * Update mask model, update TS, update aria labels * Add validation for CIRD mask
jgowdyelastic
pushed a commit
that referenced
this pull request
Jun 4, 2019
* Create IpRangeType and IpRanges controls * Add validation * Refactoring * Add behavior when discarding changes * Refactoring: create common input list * Remove old template * Move add btn to input_list, add placeholder * Remove unused directives * Remove unused translations * Refactoring * Use EuiButtonGroup instead of toggle button * Update options ids, add aria-labels * Remove unused translations * Update mask model, update TS, update aria labels * Add validation for CIRD mask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EUIfication of
IP Rangescontrol for aggregation parameter in Default Editor, Data tab.Part of #30922.
Steps to reproduce: create
Data Tablevisualization, chooseIPv4 Rangeaggregation inBucketsgroup.Details
{ from: '0.0.0.0', to: '255.255.255.255'}and{ mask: '0.0.0.0/1' }*by default.This PR also contains removing unused directives:
validateIpandvalidateCidrMask.Screenshots:
--
2) CIDR mask
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately