[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs#35444
Merged
cjcenizal merged 11 commits intoelastic:watcher-portfrom Apr 23, 2019
Merged
[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs#35444cjcenizal merged 11 commits intoelastic:watcher-portfrom
cjcenizal merged 11 commits intoelastic:watcher-portfrom
Conversation
Contributor
|
Pinging @elastic/es-ui |
…WatchList, WatchStatus, and WatchEdit.
671c596 to
85b005a
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
… to surface 404 errors.
Contributor
💔 Build Failed |
bmcconaghy
approved these changes
Apr 23, 2019
Contributor
bmcconaghy
left a comment
There was a problem hiding this comment.
LGTM thx for all the fixes
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user lacks permissions to manage watches, they'll see some feedback and be blocked from using the UI:
Currently, this only works for the edit and status routes. There's code in place to do this for the list route, but it looks like the API for fetching and listing all watches is just a simple search, and it doesn't look like the user's watch permissions affect this query. I'll follow up with the Watcher API team on this.
I also added feedback for when the API responds with a 404: