turning it all into one React app#35185
Merged
bmcconaghy merged 16 commits intoelastic:watcher-portfrom Apr 19, 2019
Merged
Conversation
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
@bmcconaghy this is awesome!
i didn't test locally yet. it looks like there are a couple files that may have been deleted accidentally.
confirm_watches_modal.tsxform_errors.tsxdelete_watches_modal.tsx
Contributor
There was a problem hiding this comment.
for my own knowledge... do we still need this now that we switched to react router?
Contributor
Author
There was a problem hiding this comment.
arguably not. probably should be using history for nav.
Contributor
There was a problem hiding this comment.
rather than passing this in as a prop, could you just import LicenseServiceContext directly from the JsonWatchEditForm component?
Contributor
Author
There was a problem hiding this comment.
good point, fixed.
Contributor
💔 Build Failed |
44f72f1 to
084a8bf
Compare
084a8bf to
048b7e7
Compare
Contributor
Author
|
@alisonelizabeth thx for the comments, pushed fixes for those things. |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
aeb2fbb to
fc60e58
Compare
Contributor
💔 Build Failed |
fc60e58 to
5237381
Compare
Contributor
💔 Build Failed |
5237381 to
97a4a99
Compare
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deletes a lot of Angular code and turns it all into one big React app. I still need to address breadcrumbs and reducing the refetching of watches, but those will get addressed in a separate PR.