Replace angular timepicker with EuiSuperDatePicker#29204
Conversation
* replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config
|
Pinging @elastic/kibana-app |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
lukasolson
left a comment
There was a problem hiding this comment.
One thing I noticed while playing around with this is that there's no way for apps to subscribe to when you click on the "refresh" button (i.e. when the time range hasn't changed but you still want to refresh your data). It might make sense as part of this PR to move the this.emit('fetch') in timefilter.js outside of the if (areTimePickerValsDifferent(... statement. What do you think?
Other than that, it is looking really great! Love seeing this finally get moved over to EUI and seeing all of those old bootstrap files get removed.
|
|
||
| // Components -- waiting on EUI conversion | ||
| @import "~ui/timepicker/timepicker"; | ||
| @import "~ui/filter_bar/filter_bar"; |
There was a problem hiding this comment.
Pretty sure this is a merge error. Both of these should be removed now.
There was a problem hiding this comment.
yep, that was a merge mistake. It has been fixed
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
Bargs
left a comment
There was a problem hiding this comment.
Given time constraints I did a pretty quick review, but the code looks good and everything seems to be working in Chrome. Assuming tests pass, LGTM.
| name: i18n.translate('kbn.advancedSettings.dateFormatTitle', { | ||
| defaultMessage: 'Date format', | ||
| }), | ||
| value: 'MMMM Do YYYY, HH:mm:ss.SSS', |
There was a problem hiding this comment.
Did this have to change for some reason?
There was a problem hiding this comment.
That is the format that design recommended so it fits in the UI better. Spelling out the month wastes a lot of space
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
@lukasolson I had to revert the moving of I will create an issue for timefilter not emitting an event when |
💔 Build Failed |
💚 Build Succeeded |
|
Created #30179 to track Clicking refresh button in Kibana top nav time picker does not cause refresh |
Update kbn_top_nav, replacing angular timepicker with EuiSuperDatePicker.
Example of application that has not disabled the timepicker in kbn-top-nav and has not enabled the timepicker in query-bar
Example of EuiSuperDatePicker in refresh only mode
