[migrations] Fetch additional mappings with types #28729
Merged
chrisdavies merged 2 commits intoelastic:masterfrom Jan 15, 2019
Merged
[migrations] Fetch additional mappings with types #28729chrisdavies merged 2 commits intoelastic:masterfrom
chrisdavies merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
dc944b6 to
da325fd
Compare
This comment has been minimized.
This comment has been minimized.
da325fd to
d04119a
Compare
This comment has been minimized.
This comment has been minimized.
Follow-up to elastic#28497 Since elastic/elasticsearch#37285 has been merged, it's aparent there are a couple more places we need to specify include_type_name as a stop-gap until elastic#23650 is completed Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
d04119a to
90dede6
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
chrisdavies
approved these changes
Jan 15, 2019
Contributor
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM. Seems reasonable as a stopgap, but I think we need to follow up by removing this, and removing doc altogether from our calls to these. I can do that as part of my work on this: #23650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #28497
Since elastic/elasticsearch#37285 has been merged, it's
apparent there are a couple more places we need to specify include_type_name
as a stop-gap until #23650 is completed