Skip to content

[Flaky-test][Dashboard] Remove sync colors tests#260509

Merged
cqliu1 merged 7 commits intoelastic:mainfrom
cqliu1:flaky-test/dashboard/sync-colors
Apr 10, 2026
Merged

[Flaky-test][Dashboard] Remove sync colors tests#260509
cqliu1 merged 7 commits intoelastic:mainfrom
cqliu1:flaky-test/dashboard/sync-colors

Conversation

@cqliu1
Copy link
Copy Markdown
Contributor

@cqliu1 cqliu1 commented Mar 31, 2026 •
edited
Loading

Summary

Closes #258148.
Closes #235883.

This deletes the sync colors settings scout tests. Per #200272, this setting will be deprecated and support for it is limit to two legacy palettes.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 31, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11312

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 39/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 2, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11356

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 6/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 3, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11357

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 0/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 4, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11378

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 34/100 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 6, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11392

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 18/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 6, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11400

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 6, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11401

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 9/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11402

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11403

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11405

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 1/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11421

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11431

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 9/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 8, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11442

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts: 9/15 tests passed.

see run history

@cqliu1 cqliu1 force-pushed the flaky-test/dashboard/sync-colors branch from 35d7757 to 6482525 Compare April 8, 2026 17:55
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v9.5.0 labels Apr 8, 2026
@cqliu1 cqliu1 marked this pull request as ready for review April 8, 2026 18:01
@cqliu1 cqliu1 requested a review from a team as a code owner April 8, 2026 18:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 8, 2026

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Apr 8, 2026
@ThomThomson ThomThomson changed the title [Flaky-test][Dashboard] Unskip sync colors tests [Flaky-test][Dashboard] Remove sync colors tests Apr 10, 2026
ThomThomson
ThomThomson approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test removal LGTM

@cqliu1 cqliu1 enabled auto-merge (squash) April 10, 2026 17:40
@cqliu1 cqliu1 merged commit 3818e9d into elastic:main Apr 10, 2026
17 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 10, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / Endpoint plugin @ess @serverless @skipInServerlessMKI When attempting to call an endpoint api "before all" hook in "@ess @serverless @skipInServerlessMKI When attempting to call an endpoint api"

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.5.0

Projects

None yet

Milestone

No milestone

4 participants

@cqliu1 @kibanamachine @elasticmachine @ThomThomson