feat(agent-builder): tool listing page for agent centric UX#259066
Merged
SiddharthMantri merged 10 commits intoelastic:ab-agent-centric-ux-feature-branchfrom Mar 23, 2026
Merged
Conversation
chrisbmar
reviewed
Mar 23, 2026
| return ( | ||
| <EuiFlyout | ||
| side="right" | ||
| size="960px" |
Contributor
There was a problem hiding this comment.
same width for all library flyouts? Shared constant 🙏🏽
Comment on lines
+68
to
+86
| const activeTools = useMemo(() => { | ||
| if (!agent) return []; | ||
| const explicitTools = allTools.filter((t) => isToolSelected(t, agentToolSelections)); | ||
| if (enableElasticCapabilities) { | ||
| const explicitIdSet = new Set(explicitTools.map((t) => t.id)); | ||
| const defaultToolsNotExplicit = allTools.filter( | ||
| (t) => defaultToolIdSet.has(t.id) && !explicitIdSet.has(t.id) | ||
| ); | ||
| return [...explicitTools, ...defaultToolsNotExplicit]; | ||
| } | ||
| return explicitTools; | ||
| }, [allTools, agentToolSelections, agent, enableElasticCapabilities, defaultToolIdSet]); | ||
|
|
||
| const activeToolIdSet = useMemo(() => new Set(activeTools.map((t) => t.id)), [activeTools]); | ||
|
|
||
| const libraryActiveToolIdSet = useMemo(() => { | ||
| if (enableElasticCapabilities) return new Set([...activeToolIdSet, ...defaultToolIdSet]); | ||
| return activeToolIdSet; | ||
| }, [activeToolIdSet, enableElasticCapabilities, defaultToolIdSet]); |
Contributor
There was a problem hiding this comment.
This logic looks great, but it's becoming a bit complex. Can you look into seeing if any of these can be pure functions that we can unit test? getActiveTools(...) would be good. But if it's more effort than its worth, ofc skip.
| </p> | ||
| </EuiText> | ||
| ) : ( | ||
| filteredActiveTools.map((tool) => { |
Contributor
There was a problem hiding this comment.
All this JSX is very hard to read, can we please refactor 🙏🏽
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]
History
|
chrisbmar
reviewed
Mar 23, 2026
| sidebarView: 'agentSettings', | ||
| navLabel: navLabels.tools, | ||
| navIcon: 'wrench', | ||
| navSection: 'Advanced', |
Contributor
There was a problem hiding this comment.
lets move this to i18n top of the file in the navSections
Contributor
Author
|
@elasticmachine merge upstream |
3f9a26e
into
elastic:ab-agent-centric-ux-feature-branch
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/13479
Summary
This PR adds a new Tool page for the chosen agent. Agent > Customize > Advanced > Tool
Screen.Recording.2026-03-23.at.13.43.02.mov