[9.2] [canvas] fix unable to load embeddable when no references are provided (#257779)#258597
Open
ThomThomson wants to merge 6 commits intoelastic:9.2from
Open
[9.2] [canvas] fix unable to load embeddable when no references are provided (#257779)#258597ThomThomson wants to merge 6 commits intoelastic:9.2from
ThomThomson wants to merge 6 commits intoelastic:9.2from
Conversation
elastic#257779) Adds BWC code to canvas that adds library reference when `savedObjectId` is provided but no reference exists. (cherry picked from commit 56c6e4f) # Conflicts: # x-pack/platform/plugins/private/canvas/server/embeddable/transform_workpad_out.ts # x-pack/platform/test/functional/apps/canvas/embeddables/lens.ts
Contributor
|
@elasticmachine merge upstream |
Contributor
|
/ci |
nreese
reviewed
Mar 23, 2026
| await canvas.addNewPage(); | ||
| await canvas.goToPreviousPage(); | ||
| await header.waitUntilLoadingHasFinished(); | ||
| // Test Workpad does not provide time range |
Contributor
There was a problem hiding this comment.
Comment is no longer correct and can be removed
nreese
reviewed
Mar 23, 2026
| // TODO remove when lens as code transforms are ready for production | ||
| const transformType = embeddableType === 'lens' ? 'lens-dashboard-app' : embeddableType; | ||
| const transforms = embeddableService.getTransforms(transformType); | ||
| fn.arguments.type[0] = embeddableType; |
Contributor
There was a problem hiding this comment.
Setting type not needed since its value does not change
nreese
approved these changes
Mar 23, 2026
Contributor
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation