[9.3] [Write-restricted dashboards] Update user profile retrieval for getShouldAddAccessControl (#255065)#257050
Merged
kibanamachine merged 2 commits intoelastic:9.3from Mar 11, 2026
Conversation
…ouldAddAccessControl (elastic#255065) ## Summary This PR changes how the dashboard save modal determines if access control metadata should be added to a dashboard. Previously it used the user profile service, however, since elastic#249839, the getCurrent function now attempts to retrieve the user profile when the incoming request is authenticated via Basic or API key. This resulted in adding the access control metadata when authenticated to the UI via a proxy or the anonymous authc provider. The Saved Object Repository does not use the user profiles service to determine the current user, but rather the authentication service, which does not retrieve the user profile when authenticated via API key. This caused errors when creating dashboards in the UI when authenticated via a proxy or the anonymous authc provider - the UI would add the access control meta data and the SO repository would reject the operation due to lacking a profile ID for the owner field. This PR implements a short term solution by switching to the authentication service in the dashboard save modal - matching the mechanism of checking for an active profile ID in the SO repository. A longer-term solution might be different, should we want to support creating dashboards with access control via API key. In this case, we would need to modify the SO repository code (actually, the security extension), if feasible, to use the user profile service. However, his may introduce too much overhead. ### Testing The easiest way to test this fix is to configure the anonymous authentication provider. When users are authenticated anonymously they do not activate a user profile. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... ## Release note Fixes an issue where saving a dashboard included access control features when a user profile, which is required for access control, was not available. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 009aea1)
Merged
10 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @jeramysoucy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation