[6.x] Combine common pdf png functions (#25152)#25639
Merged
stacey-gammon merged 1 commit intoelastic:6.xfrom Nov 14, 2018
Merged
[6.x] Combine common pdf png functions (#25152)#25639stacey-gammon merged 1 commit intoelastic:6.xfrom
stacey-gammon merged 1 commit intoelastic:6.xfrom
Conversation
* Create common routines for PDF and PNG report processing * REmove Blacklisted headers not needed * Changes for issues with PDF and PNG testing As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300. * removed uneccesary image compare routine * Moved server from property on job to passed in parameter. * consolidated PDF and PNG testing Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions. * Typescripted the common functions and broke out tests to individual test files * Create a common create mock server function that all new tests call * Removed unnecessary exception check and removed test include from index.ts
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports #25152
Create common routines for PDF and PNG report processing
REmove Blacklisted headers not needed
Changes for issues with PDF and PNG testing
As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300.
removed uneccesary image compare routine
Moved server from property on job to passed in parameter.
consolidated PDF and PNG testing
Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.
Typescripted the common functions and broke out tests to individual test files
Create a common create mock server function that all new tests call
Removed unnecessary exception check and removed test include from index.ts
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers