Skip to content

[6.x] Combine common pdf png functions (#25152)#25639

Merged
stacey-gammon merged 1 commit intoelastic:6.xfrom
stacey-gammon:6.x/common-png-functions
Nov 14, 2018
Merged

[6.x] Combine common pdf png functions (#25152)#25639
stacey-gammon merged 1 commit intoelastic:6.xfrom
stacey-gammon:6.x/common-png-functions

Conversation

@stacey-gammon
Copy link
Copy Markdown

backports #25152

  • Create common routines for PDF and PNG report processing

  • REmove Blacklisted headers not needed

  • Changes for issues with PDF and PNG testing

As per Joel Griffith suggestion I added removal of toast notifications after each click download report. And removed setting of image density to 300.

  • removed uneccesary image compare routine

  • Moved server from property on job to passed in parameter.

  • consolidated PDF and PNG testing

Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.

  • Typescripted the common functions and broke out tests to individual test files

  • Create a common create mock server function that all new tests call

  • Removed unnecessary exception check and removed test include from index.ts

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

* Create common routines for PDF and PNG report processing

* REmove Blacklisted headers not needed

* Changes for issues with PDF and PNG testing

As per Joel Griffith suggestion I added removal of toast notifications after each click download report.  And removed setting of image density to 300.

* removed uneccesary image compare routine

* Moved server from property on job to passed in parameter.

* consolidated PDF and PNG testing

Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.

* Typescripted the common functions and broke out tests to individual test files

* Create a common create mock server function that all new tests call

* Removed unnecessary exception check and removed test include from index.ts
@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Nov 14, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit 171e1bc into elastic:6.x Nov 14, 2018
@stacey-gammon stacey-gammon deleted the 6.x/common-png-functions branch February 12, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants