Conversation
ensures they work as expected with the new form layout design
- additionally updates some usages of controls to align compressed styles
- updates button group wrapper width to account for changed button widths - removes custom height style as the new EuiFormPrepend component handles styling and positioning by itself
- mainly updates due to emotion style updates on EuiButtonEmpty + changes to form layouts
- related to color token changes
515b7f9 to
8218281
Compare
|
Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/733 |
src/platform/packages/private/kbn-controls-renderer/src/components/control_panel.tsx
Show resolved
Hide resolved
peteharverson
left a comment
There was a problem hiding this comment.
Tested ML changes and LGTM
|
@elasticmachine merge upstream |
CAWilson94
left a comment
There was a problem hiding this comment.
LGTM reviewed Entity Analytics changes 🚀
consulthys
left a comment
There was a problem hiding this comment.
LGT Stack Monitoring
Thanks for the work!
CoenWarmer
left a comment
There was a problem hiding this comment.
Checked out locally and reviewed Streams App. LGTM!
|
LGTM reviewed csp changes. |
MiriamAparicio
left a comment
There was a problem hiding this comment.
Changes in obs-presentation look good to me
mariairiartef
left a comment
There was a problem hiding this comment.
Visualization changes LGTM
There was a problem hiding this comment.
LGTM @mgadewoll thanks for making this work. kibana-design.
sdesalas
left a comment
There was a problem hiding this comment.
Tested Detection Rules locally using PR branch and everything looks good. Nice work. Thanks @mgadewoll. 😁
ThomThomson
left a comment
There was a problem hiding this comment.
Design changes LGTM & read through code. Very nice!
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @mgadewoll |
Dependency updates
@elastic/eui- v112.3.0 ⏩ v113.0.0@elastic/eui-theme-borealis- v5.4.0 ⏩ v6.0.0@elastic/eslint-plugin-eui- v2.8.0 ⏩ v2.9.0Changes
EuiFormPrependandEuiFormAppend(EUI #9308)Important
❗ This upgrade PR includes all changes previously made in the specific QA PR #248805.
Please see the description in that PR for detailed information about the specific changes.
Note
🔗 Please see the section "Additional changes" in #248805 for an overview of additional changes.
ghostandinktoken usages withtextInkorplainDarkandtextGhostorplainLightrespectively (EUI #9379)Package updates
@elastic/euiv113.0.0EuiFlyoutmanager to close all flyouts when a parent flyout is closed. (#9378)textInkandtextGhostcolor tokens for text and icon colors that should always remain dark or light regardless of color mode. (#9379)EuiFormAppendandEuiFormPrependcomponents (#9014)type="span"onEuiFormLabelfor visual-only form labels (#9014)EuiFormLabelto render aspanif nohtmlForis passed (#9014)EuiFormControlLayoutto useEuiFormAppendandEuiFormPrepend(#9014)EuiAutoRefreshandEuiColorPickerto useEuiFormPrepend(#9014)EuiFormAppend/EuiFormPrependstyling (#9305)EuiFormAppend/EuiFormPrependto inheritisDisabledstate fromEuiFormControlLayout(#9305)EuiFormControlLayouthover, disabled and readonly styling (#9305)EuiFormControlButtonto inheritisDisabled,readOnlyandisInvalidstates fromEuiFormControlLayout(#9305)iconSideprop onEuiDatePickerRange(#9305)EuiSuperDatePickervalid state styling (#9305)EuiButtonEmpty(other button variants don't have a transition anymore either) (#9305)isLoadingprop onEuiFormControlButton(#9328)EuiButton,EuiButtonEmpty,EuiFilterButton(#8948)append/prependonEuiFormControlLayout(#8948)scrollContainerRefprop toEuiFlyoutBodyfor accessing the flyout's internal scroll container. (#9373)Bug fixes
EuiColorPickerto ensureidis correctly passed onto the internalEuiFormControlLayout(#9014)Breaking changes
inkandghosttheme tokens. UsetextInk/textGhostfor text and icon colors orplainDark/plainLightfor non-text use cases. (#9379)EuiQuickSelectPopoverinEuiSuperDatePickerto useEuiFormPrepend. This results in more restrictedbuttonPropsas they reflectEuiFormPrependinstead of genericEuiButtonEmptyprops. (#9014)components.superDatePickerBackgroundSucceestoken (#9305)@elastic/eui-theme-borealisv6.0.0textInkandtextGhostcolor tokens for text and icon colors that should always remain dark or light regardless of color mode. (#9379)@elastic/eslint-plugin-euiv2.9.0badge-accessibility-rulesrule autofix from duplicatingaria-hiddenattributes. (#9366)badge-accessibility-rulesrule validation when a spread operator is used in a component. (#9366)