[ResponseOps] Skip director on non alertable rules#251916
Merged
cnasikas merged 1 commit intoelastic:alerting_v2from Feb 5, 2026
Merged
[ResponseOps] Skip director on non alertable rules#251916cnasikas merged 1 commit intoelastic:alerting_v2from
cnasikas merged 1 commit intoelastic:alerting_v2from
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
my reviews don't matter anyway |
Member
Author
|
They matter!! I can merge to a feature branch even without a review from anyone. But having approval from someone from the RnA team allows me to proceed. |
Contributor
💔 Build Failed
Failed CI StepsHistorycc @cnasikas |
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips running the director if the rule is not alertable.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.