[9.3] [a11y] Fix Eui modal title annoucment (#250459)#250987
Merged
kibanamachine merged 1 commit intoelastic:9.3from Jan 29, 2026
Merged
[9.3] [a11y] Fix Eui modal title annoucment (#250459)#250987kibanamachine merged 1 commit intoelastic:9.3from
kibanamachine merged 1 commit intoelastic:9.3from
Conversation
## Summary Currently, create query rules set model header is set to default component which is `<h1>`. This causes voiceover to announce as heading level 1, this cause a bit of confusion as the actua pagel has heading level 1 as "Query rules". Changing to use `<div>` tag, so that heading would not be annouced as h1. Additionally, i have also added inital focus to text field. https://github.com/user-attachments/assets/2e4f14f6-76a5-4114-ac61-1a14866416b4 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) (cherry picked from commit bcaea17)
1 task
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation