Pinging @elastic/obs-onboarding-team (Team:obs-onboarding)

Issue: Missing React key on Fragment

In internal_networks_selector.tsx, the .map() renders a bare fragment <> that wraps EuiCheckableCard + EuiSpacer, but the key prop is placed on EuiCheckableCard instead of the fragment. Since <> (shorthand fragment) doesn't accept props, React will emit a key warning for the list items.

// Current (key is on inner element, not the fragment):
{internalNetworksOptions.map(({ id, label, content }) => (
  <>
    <EuiCheckableCard key={id} ...>
    <EuiSpacer size="s" />
  </>
))}

// Should be:
{internalNetworksOptions.map(({ id, label, content }) => (
  <React.Fragment key={id}>
    <EuiCheckableCard id={id} ...>
    <EuiSpacer size="s" />
  </React.Fragment>
))}

Fixed with 8b78167

Nice, works great 👌

Just a question about the field selection before I approve. Usually we allow the suggetions plus free form selection, but here it looks like there's no free form option. Is that on purpose? vs

@Kerry350 My intention behind that was to prevent the "add as a custom field" default option as the custom field would be empty.

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: f199dcb

Failed CI Steps

• Jest Tests #3
• Scout: [ observability / apm ] plugin

Test Failures

• [job] [logs] Jest Tests #3 / ChangePasswordModal render disables submit button when passwords do not match
• [job] [logs] Scout: [ observability / apm ] plugin / local-stateful-classic - Service map - accessibility - keyboard navigation works correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

History

• 💛 Build #395312 was flaky 7bbcf9d
• 💔 Build #393477 failed fc947e2
• 💔 Build #393464 failed c5a01a4
• 💔 Build #393336 failed 234a867
• 💔 Build #393237 failed 0c125bc
• 💔 Build #393227 failed 7d7fa53