Skip to content

[obs-onboarding-team] Remove node-fetch dependency in favor of native fetch#250722

Merged
afharo merged 2 commits intoelastic:mainfrom
afharo:remove-node-fetch/obs-onboarding
Feb 4, 2026
Merged

[obs-onboarding-team] Remove node-fetch dependency in favor of native fetch#250722
afharo merged 2 commits intoelastic:mainfrom
afharo:remove-node-fetch/obs-onboarding

Conversation

@afharo
Copy link
Copy Markdown
Member

@afharo afharo commented Jan 28, 2026

Summary

This PR removes the node-fetch dependency for files owned by @elastic/obs-onboarding-team and related observability teams.

Why

Node.js 18+ includes a native fetch API (built on undici internally), making the node-fetch package unnecessary. This reduces the dependency footprint by removing one runtime dependency and its transitive dependencies.

Changes

  • Updated kbn-otel-demo enable_streams utility to use native fetch
  • Updated kbn-evals-suite-streams evaluation scripts
  • Updated cloud integration and scalability test utilities
  • Updated alerting-test-data Kibana URL utilities
  • Updated observability_ai_assistant_app evaluation scripts

Warning

These changes were vibe-coded using the AI agent claude-4.5-opus-high. Please review carefully.

Test plan

  • Type check passes
  • ESLint passes
  • Unit tests pass for modified files

… fetch

## Changes
- Updated kbn-otel-demo enable_streams utility
- Updated kbn-evals-suite-streams evaluation scripts
- Updated cloud integration and scalability tests
- Updated alerting test data utilities
- Updated observability AI assistant evaluation scripts

> [!WARNING]
> These changes were vibe-coded using the AI agent `claude-4.5-opus-high`. Please review carefully.
@afharo afharo requested review from a team as code owners January 28, 2026 13:15
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jan 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@afharo afharo added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:QA Platform QA t// Team:obs-onboarding Observability Onboarding Team Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ai Observability AI team labels Jan 28, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-qa (Team:QA)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/actionable-obs-team (Team:actionable-obs)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ai-team (Team:obs-ai)

Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/platform/test/scalability/events_shipper.ts changes LGTM

@afharo afharo enabled auto-merge (squash) January 28, 2026 17:00
Copy link
Copy Markdown
Contributor

@baileycash-elastic baileycash-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionable obs changes lgtm

@elasticmachine
Copy link
Copy Markdown
Contributor

⏳ Build in-progress

History

@afharo afharo merged commit 2e012d3 into elastic:main Feb 4, 2026
18 checks passed
@afharo afharo deleted the remove-node-fetch/obs-onboarding branch February 4, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:obs-ai Observability AI team Team:obs-onboarding Observability Onboarding Team Team:QA Platform QA t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants