[Discover] Fix readonly badge for new app menu#250334
Merged
davismcphee merged 5 commits intoelastic:mainfrom Jan 26, 2026
Merged
[Discover] Fix readonly badge for new app menu#250334davismcphee merged 5 commits intoelastic:mainfrom
davismcphee merged 5 commits intoelastic:mainfrom
Conversation
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10585[❌] x-pack/platform/test/functional/apps/discover/group2/config.ts: 0/25 tests passed. |
davismcphee
commented
Jan 26, 2026
| data-test-subj="header-breadcrumbs-badge-group" | ||
| css={css` | ||
| margin-left: ${isFirst ? euiTheme.size.xs : 0}; | ||
| align-items: center; |
Contributor
Author
There was a problem hiding this comment.
This is to make sure icon-only (e.g. readonly) and regular badges are vertically centered, otherwise they're misaligned.
Contributor
💔 Build Failed
Failed CI StepsHistorycc @davismcphee |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
Author
|
Been fighting a flaky test with this one. Not sure if I've fixed it yet, but publishing anyway since it's otherwise ready for review. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10586[✅] x-pack/platform/test/functional/apps/discover/group2/config.ts: 25/25 tests passed. |
kowalczyk-krzysztof
approved these changes
Jan 26, 2026
Member
kowalczyk-krzysztof
left a comment
There was a problem hiding this comment.
Thanks for working on this, LGTM
jughosta
approved these changes
Jan 26, 2026
Contributor
jughosta
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing it so quickly! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #246156. This PR fixes the readonly badge in Discover, which was not showing in solution views after the new app menu changes. Since the
chrome.setBadgeAPI previously used doesn't work now that Discover's app menu is in the tabs bar, the code has been updated to use the samechrome.setBreadcrumbsBadgesAPI that the managed and context awareness badges use.The readonly badge should appear in the same circumstances as before but directly next to the breadcrumbs (always the first badge), whether in classic or solution view. It should remain there while in the main app, surrounding docs, or single doc, and be removed when leaving Discover. I've also reordered the managed badge to appear next to the readonly badge when both are visible.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Closes: https://github.com/elastic/kibana-team/issues/2713