Skip to content

[Discover] Remove unused Discover customizations#250333

Merged
davismcphee merged 4 commits intoelastic:mainfrom
davismcphee:discover-remove-unused-customizations
Jan 26, 2026
Merged

[Discover] Remove unused Discover customizations#250333
davismcphee merged 4 commits intoelastic:mainfrom
davismcphee:discover-remove-unused-customizations

Conversation

@davismcphee
Copy link
Copy Markdown
Contributor

Summary

Follow up to #246156. It was pointed out in that PR that the Discover customizations example was broken due to changes related to the top nav customization. This PR fixes the issue, but also removes all the unused Discover customizations from the codebase. This is a legacy system we're trying to move away from in favour of context awareness, and they're a maintenance burden that provide no benefit.

The following customizations have been removed, and the only two remaining are the ones currently used by Timelines:

  • Top nav
  • Data table
  • Field list
  • Flyout

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@davismcphee davismcphee self-assigned this Jan 26, 2026
@davismcphee davismcphee added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Jan 26, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 2067 2065 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 161 151 -10
unifiedDocViewer 17 44 +27
total +17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.5MB 1.5MB -3.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 28 21 -7
unifiedDocViewer 5 4 -1
total -8

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 25.5KB 25.5KB -9.0B
Unknown metric groups

API count

id before after diff
discover 205 195 -10
unifiedDocViewer 26 53 +27
total +17

async chunk count

id before after diff
discover 43 42 -1

cc @davismcphee

@davismcphee davismcphee marked this pull request as ready for review January 26, 2026 03:44
@davismcphee davismcphee requested a review from a team as a code owner January 26, 2026 03:44
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee merged commit 219ae02 into elastic:main Jan 26, 2026
29 checks passed
@davismcphee davismcphee deleted the discover-remove-unused-customizations branch January 26, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants